Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag analytical cluster #583

Merged
merged 31 commits into from
Oct 8, 2024
Merged

feat: tag analytical cluster #583

merged 31 commits into from
Oct 8, 2024

Conversation

wai-wong-edb
Copy link
Collaborator

No description provided.

# Conflicts:
#	pkg/api/tag_client.go
# Conflicts:
#	examples/resources/biganimal_cluster/ha/resource.tf
#	examples/resources/biganimal_cluster/single_node/aws/resource.tf
#	examples/resources/biganimal_cluster/single_node/azure/resource.tf
#	examples/resources/biganimal_cluster/single_node/bah_aws/resource.tf
#	examples/resources/biganimal_cluster/single_node/bah_azure/resource.tf
#	examples/resources/biganimal_cluster/single_node/bah_gcp/resource.tf
#	examples/resources/biganimal_cluster/single_node/gcp/resource.tf
#	examples/resources/biganimal_cluster/single_node/resource.tf
#	examples/resources/biganimal_faraway_replica/aws/resource.tf
#	examples/resources/biganimal_faraway_replica/azure/resource.tf
#	examples/resources/biganimal_faraway_replica/cluster_and_faraway_replica/resource.tf
#	examples/resources/biganimal_faraway_replica/gcp/resource.tf
#	examples/resources/biganimal_faraway_replica/resource.tf
#	examples/resources/biganimal_pgd/aws/bah_data_group/resource.tf
#	examples/resources/biganimal_pgd/aws/bah_data_groups_with_witness_group/resource.tf
#	examples/resources/biganimal_pgd/azure/bah_data_group/resource.tf
#	examples/resources/biganimal_pgd/azure/bah_data_groups_with_witness_group/resource.tf
#	examples/resources/biganimal_pgd/gcp/bah_data_group/resource.tf
#	examples/resources/biganimal_pgd/gcp/bah_data_groups_with_witness_group/resource.tf
#	examples/resources/biganimal_tag/resource.tf
#	pkg/api/tag_client.go
#	pkg/models/cluster.go
#	pkg/provider/provider.go
#	pkg/provider/resource_cluster.go
#	pkg/provider/resource_fareplica.go
#	pkg/provider/resource_pgd.go
#	pkg/provider/resource_tag.go
# Conflicts:
#	examples/resources/biganimal_cluster/ha/resource.tf
#	examples/resources/biganimal_cluster/single_node/aws/resource.tf
#	examples/resources/biganimal_cluster/single_node/azure/resource.tf
#	examples/resources/biganimal_cluster/single_node/gcp/resource.tf
#	examples/resources/biganimal_faraway_replica/aws/resource.tf
#	examples/resources/biganimal_faraway_replica/azure/resource.tf
#	examples/resources/biganimal_faraway_replica/cluster_and_faraway_replica/resource.tf
#	examples/resources/biganimal_faraway_replica/gcp/resource.tf
#	pkg/provider/resource_cluster.go
#	pkg/provider/resource_fareplica.go
…oject

# Conflicts:
#	pkg/provider/resource_cluster.go
@wai-wong-edb wai-wong-edb changed the base branch from main to ww-tag-assign-project August 22, 2024 16:46
Copy link
Contributor

@vishalsawale9 vishalsawale9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few neat comments, but it looks good to me overall.

Base automatically changed from ww-tag-assign-project to main October 3, 2024 13:16
# Conflicts:
#	pkg/provider/common.go
#	pkg/provider/resource_cluster.go
Copy link
Collaborator

@edbamolvyavahare edbamolvyavahare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wai-wong-edb wai-wong-edb merged commit 1f5717c into main Oct 8, 2024
7 checks passed
@wai-wong-edb wai-wong-edb deleted the ww-tag-analytical-cluster branch October 8, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants