-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iss194 reliable delivery batch upload #447
base: develop
Are you sure you want to change the base?
Conversation
…taPublisher::storAndPublish()
Is there a reason you always use "que" instead of queue? Could you change to queue, especially for function names? |
labels are a label so long as unique. Though I see what you mean its not very unique . Will work on it. :) |
I wonder if you managed to compile it and or unit test it. I was hoping to make it easy for it to be at least verified. :) |
I've compiled it, but I haven't tested it yet. |
Ok thanks for the info. |
I'm slowly taking tiny steps working to understand your code. I've been able to test the code and see that it mostly works, but there are a lot of compiler warnings and that I want to have fixed and more things that need to be documented. |
Hey good to hear. Let me know. Intrigued as to what tests you've done, and what cases you are trying that aren't working out.? Though as I mentioned earlier, I did do the PR against my 'development' branch (rel1_dvlp1m) - which maybe was a mistake, Here is the output of my compile, that was based off (master) for what I did a PR on, I don't see any warnings for the code I submitted
|
Processing mayfly (board: mayfly; platform: atmelavr; framework: arduino)Verbose mode can be enabled via
Environment Status Duration mayfly SUCCESS 00:02:59.516 |
weeelll fantastic - I supplied a version !!... you've modified it, done some testing - and these are pretty easy fixes above if that's your comments. Wells its funny , just been part of capstone engineering project for final year engineers - part of this process is to bring out the "technical conversation " the value for specifications, technical requirements and then testing to them. So to recap, I defined the context of the submission , described the algorithms and I believe it was agreed to
|
If you publish your test framework happy to look at your changes :) |
@neilh10. I'm sorry; I didn't intend to push directly to your branch. I'll try to fix the git. |
ba6a7d6
to
8f8680f
Compare
Ok I've been away. It looks to me like you put all the changes on a branch (reliable_delivery). BTW a test run that I did last weekend with my production software and over SIM7080G and ATT (through dataplans.digikey), had good success - which is verifying my fork of the the SIMComSIM7080 and SIM7080G/57600K and the MMW response. ODM2/ODM2DataSharingPortal#673 (comment) |
Just wondering if any visibility on this merge. Related #194 |
Per description update in #194
basic merge to (develop) describied in ModularSensors\a\mayfly2_wifi_s6b\Readme.md
Test module built with PIO
Two test modules run over weekend with good test results. Will share data separately in next couple of days.
Two test modules built as "alpha" testing from,
ModularSensors\a\mayfly1_wifi_wroom
ModularSensors\a\mayfly2_wifi_s6b
Not tested promoting to examples and building to the branch, but I wouldn't expect in module changes.
My fork has support for the RTC of the SAMD51 which is slightly different than SAMD21 - disentangling this is a bit challenging, so a few misc statements may refer to this.