Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UndefVarError: ST not defined #1019

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix UndefVarError: ST not defined #1019

merged 1 commit into from
Aug 21, 2023

Conversation

devmotion
Copy link
Contributor

A large number of errors in TuringLang/DistributionsAD.jl#254 are caused by an UndefVarError: ST not defined. The logs (see, e.g., https://github.com/TuringLang/DistributionsAD.jl/actions/runs/5872312798/job/16026479059#step:6:47460 https://github.com/TuringLang/DistributionsAD.jl/actions/runs/5872312798/job/16026479059#step:6:47460) point to line 2619 in src/compiler.jl.

This PR ensures that variable ST is defined by copying definitions from other functions in src/compiler.jl - since I don't know what they are doing, I don't know if this suggestion is correct.

While looking at src/compiler.jl, I noticed that the same problem should be present in line 2640, and hence I applied the same suggestions there as well.

I don't have a simple MWE, so no test is added.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (026696b) 77.49% compared to head (f4dc70c) 77.46%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
- Coverage   77.49%   77.46%   -0.04%     
==========================================
  Files          19       19              
  Lines        8892     8896       +4     
==========================================
  Hits         6891     6891              
- Misses       2001     2005       +4     
Files Changed Coverage Δ
src/compiler.jl 78.28% <0.00%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses wsmoses merged commit 628c9a4 into EnzymeAD:main Aug 21, 2023
32 of 39 checks passed
@wsmoses
Copy link
Member

wsmoses commented Aug 21, 2023

FYI @devmotion this is actually an error in the error handler code.

Specifically the code meant to apply to a type unstable splat in vector mode (which is presently unsupported). This will get past this, but also likely indicates there is a part of the code that cannot currently be differentiated (which hopefully now will be identified by a backtrace).

@devmotion devmotion deleted the dw/ST branch August 21, 2023 05:52
michel2323 pushed a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants