-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test more BLAS functions #1046
base: main
Are you sure you want to change the base?
Test more BLAS functions #1046
Conversation
Answering your question from your old PR, I have not enabled the tablegen rules by default yet. Here is the related code: Line 8822 in 744ffce
|
@sethaxen can you mark the currently failing tests as skipped (and open corresponding issues) |
@sethaxen 1.6 fails for unrelated reasons. All of the "local" ones have the fix (aka it requires a new jll with the fix, which we haven't yet released). That fixed your issue for me. 1.7+ have different GC assertion errors. If you can isolate the cause, I can try to include a fix in the same jll release. |
jll bump has landed, so updating this, CI should have that fix. The remaining failures still need investigation if you're able @sethaxen |
Thanks! I'll check later. For some reason dotu and dotc started failing and not I think from changes I made. Still trying to isolate the cause. |
bumping @sethaxen if you've had a chance to isolate? |
No, this turned out to be much more time-consuming than anticipated, and I don't think I'll be able to finish it soon. It should be fairly straightforward to finish if someone else wants to take it on, just slow to identify which tests will cause Julia to crash, which need to be marked broken, and what the MWE is for an issue. |
a5f78a0
to
821ee95
Compare
Julia getting incorrect DiffeUse info, causing gc to free too early? Or is that something else? |
GC related for sure, how or what causes is unclear |
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
This PR adds tests using EnzymeTestUtils for
BLAS.scal!
BLAS.axpy!
BLAS.gemv!
BLAS.spmv!
BLAS.gemm!