Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turing integration tests #1813

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mhauru
Copy link
Contributor

@mhauru mhauru commented Sep 12, 2024

Makes log density functions out of a bunch of Turing.jl models and checks that Enzyme can differentiate them, both in Forward and Reverse modes.

Related issues that should probably be sorted before merging this:

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.92%. Comparing base (037dfed) to head (6154f90).
Report is 61 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1813      +/-   ##
==========================================
+ Coverage   67.50%   69.92%   +2.41%     
==========================================
  Files          31       32       +1     
  Lines       12668    13645     +977     
==========================================
+ Hits         8552     9541     +989     
+ Misses       4116     4104      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses
Copy link
Member

wsmoses commented Sep 12, 2024 via email

@mhauru
Copy link
Contributor Author

mhauru commented Sep 12, 2024

I changed the dependency from Turing to DynamicPPL and Distributions since we don't do any sampling. I pinnned those two and their major depencencies: AbstractMCMC, AbstractPPL, Bijectors, LogDensityProblems, LogDensityProblemsAD. Can pin all the dependencies if you'd like (BangBang, OrderedCollections, etc.), but I wonder if in that case it would make more sense to just commit the Manifest.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants