Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recursive map generalizing the make_zero mechanism #1852

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add recursive map generalizing the make_zero mechanism #1852

wants to merge 8 commits into from

Commits on Oct 31, 2024

  1. Add recursive_map and base make_zero(!) on it

    @danielwe
    danielwe committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    72bda99 View commit details
    Browse the repository at this point in the history

  2. Fix typos and some minor things

    @danielwe
    danielwe committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b3f7426 View commit details
    Browse the repository at this point in the history

  3. Fix Holomorphic tests 

    Eventually, `recursive_accumulate` should be rewritten on top of a new
`VectorSpace` wrapper built on `recursive_map`. Until then, this will
do.
    @danielwe
    danielwe committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1778ebe View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Docstring tweaks

    @danielwe
    danielwe committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    9f60f1d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Add fast path for recursive_map on vector types

    @danielwe
    danielwe committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    dbac66b View commit details
    Browse the repository at this point in the history

  2. Make recursive_map use guaranteed_const by default 

    But make it customizable via an argument.

Dynamic dispatch in guaranteed_const_nongen is too much of a performance
killer
    @danielwe
    danielwe committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    2f4d7eb View commit details
    Browse the repository at this point in the history

  3. fixup! Make recursive_map use guaranteed_const by default

    @danielwe
    danielwe committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    0476665 View commit details
    Browse the repository at this point in the history

  4. Factor out default arg values from logic 

    Avoid the situation where a method with optional args calls another
method where the same args are optional. It's a recipe for silent bugs
where a non-default arg gets dropped.
    @danielwe
    danielwe committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    530c780 View commit details
    Browse the repository at this point in the history