fix: overload the main methods

EnzymeAD · Dec 24, 2024 · 2f53601 · 2f53601
1 parent 190148b
commit 2f53601
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 28 deletions.
diff --git a/src/Overlay.jl b/src/Overlay.jl
@@ -115,26 +115,3 @@ for randfun in (:rand, :randn, :randexp)
         # end
     end
 end
-
-# Type Conversions
-## We don't define it outside our interpreter since it is inconsistent with how it is
-## defined in Base for other types like Complex
-@reactant_overlay @noinline function (::Type{T})(x::TracedRNumber) where {T<:Number}
-    return TracedUtils.promote_to(TracedRNumber{T}, x)
-end
-
-@reactant_overlay @noinline function (::Type{TracedRNumber{T}})(x::TracedRNumber) where {T}
-    return TracedUtils.promote_to(TracedRNumber{T}, x)
-end
-
-@reactant_overlay @noinline function Base.convert(
-    ::Type{T}, x::TracedRNumber
-) where {T<:Number}
-    return TracedUtils.promote_to(TracedRNumber{T}, x)
-end
-
-@reactant_overlay @noinline function Base.convert(
-    ::Type{TracedRNumber{T}}, x::TracedRNumber
-) where {T<:Number}
-    return TracedUtils.promote_to(TracedRNumber{T}, x)
-end
diff --git a/src/TracedRNumber.jl b/src/TracedRNumber.jl
@@ -22,10 +22,6 @@ function Base.eps(::Type{TracedRNumber{T}}) where {T}
     return TracedUtils.promote_to(TracedRNumber{T}, eps(T))
 end
 
-function Base.convert(::Type{TracedRNumber{T}}, x::Number) where {T}
-    return TracedUtils.promote_to(TracedRNumber{T}, T(x))
-end
-
 function Base.show(io::IOty, X::TracedRNumber{T}) where {T,IOty<:Union{IO,IOContext}}
     return print(io, "TracedRNumber{", T, "}(", X.paths, ")")
 end
@@ -49,9 +45,15 @@ function Base.promote_rule(::Type{T}, ::Type{TracedRNumber{S}}) where {T,S}
     return TracedRNumber{Base.promote_type(T, S)}
 end
 
+# NOTE: This is inconsistent with the behavior of `convert` but we do it since it is a very
+#       common usecase
 TracedRNumber{T}(x::TracedRNumber{T}) where {T} = x
+TracedRNumber{T}(x::TracedRNumber) where {T} = TracedUtils.promote_to(TracedRNumber{T}, x)
+TracedRNumber{T}(x::Number) where {T} = TracedUtils.promote_to(TracedRNumber{T}, x)
 
-function TracedRNumber{T}(x::Number) where {T}
+(T::Type{<:Number})(x::TracedRNumber) = TracedUtils.promote_to(TracedRNumber{T}, x)
+
+function Base.convert(::Type{TracedRNumber{T}}, x::Number) where {T}
     return TracedUtils.promote_to(TracedRNumber{T}, x)
 end