broadcast to size fix reduce

EnzymeAD · Jun 17, 2024 · 97822fe · 97822fe
1 parent 5f03906
commit 97822fe
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/overloads.jl b/src/overloads.jl
@@ -881,7 +881,7 @@ function Base.mapreduce(
     )
 
     res = MLIR.IR.block!(fnbody) do
-        tmp = broadcast_to_size(op(args...), (1,)).mlir_data
+        tmp = broadcast_to_size(op(args...), ()).mlir_data
         MLIR.Dialects.stablehlo.return_(MLIR.IR.Value[tmp])
         return tmp
     end

diff --git a/test/basic.jl b/test/basic.jl
@@ -8,6 +8,24 @@ fastmax(x::AbstractArray{T}) where {T} = reduce(max, x; dims=1, init=float(T)(-I
 
 using InteractiveUtils
 
+@testset "2D sum" begin
+    r_res = sum(ones(2, 10))
+
+    a = Reactant.ConcreteRArray(ones(2, 10))
+
+    c_res = sum(a)
+    @test c_res ≈ r_res
+
+    f = Reactant.compile(sum, (a,))
+
+    @show @code_typed f(a)
+    @show @code_llvm f(a)
+
+    f_res = f(a)
+
+    @test f_res ≈ r_res
+end
+
 @testset "Basic reduce max" begin
     r_res = fastmax(ones(2, 10))