Update MLIR code with dynamic dispatch #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I formatted the code because there were formatting inconsistencies (e.g. sometimes tab indenting, others space indenting) and it was giving me problems with auto-save formatting and git committing. I guess it's not a problem. |
|
Refactored the PR so it modifies less files. "CI / Documentation" is crashing due to other reasons. |
|
This PR will be reopened when Reactant is more stable and we can replace the local MLIR.jl copy for the upstream dep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the code to use the
ScopedValue-based dynamic dispatch.This allows to change libMLIR dynamically while using upstream MLIR.jl package, so the replicated MLIR code can be removed.