stablehlo.sort Ops

[glou-nes]

@mofeing I keep the initial signature, do we need the generalized version of the specification?

[mofeing]

mmm why a global?

[glou-nes]

Thank! leaked debug variable...

[mofeing]

forcing this to be a Function can give us problems if we want to use a functor

i think it's better to remove the condition maybe?

[glou-nes]

Sure I will relax it, do you have a example of functor?

[mofeing]

a functor is just any object that can behave as a function. like a struct which you can call:

struct Functor
    x::Int
end

(functor::Functor)(y) = functor.x + y

as an example in Julia, closures are functors

[mofeing]

this means that you can't put a type param there to select functors

[glou-nes]

Alright Closure <: Function so that can work. The pattern with struct cannot work that way. I remove the bound.

[mofeing]

exactly

[mofeing]

wait, calling result on a Type works?

[glou-nes]

yes!

[mofeing]

and what are the semantics? like what is the result of a Type??

[glou-nes]

From the MLIR type system grammar, function-type ::= (type | type-list-parens) -> (type | type-list-parens). On a function type, it returns the type result of the function.

[mofeing]

maybe we can do sth simpler like in hlo_call or such? @Pangoraw @jumerckx this pattern of tracing over a function to latter inject it into a Ops is starting to repeat (and will need it for if and while). is there an abstraction for it?

[glou-nes]

I need the no_args_in_result here. Probably waiting interpreter and functions caching PRs.

[mofeing]

thanks @glou-nes

i left some comments that i think also needs revision from some other people

[wsmoses]

tests presently fail per

  UndefVarError: `ConcreteRNumber` not defined
  Stacktrace:
    [1] sort(x::Reactant.TracedRArray{Float64, 3}; comparator::Function, dimension::Int64, is_stable::Bool, location::Reactant.MLIR.IR.Location)
      @ Reactant.Ops ~/work/Reactant.jl/Reactant.jl/src/Ops.jl:964
    [2] sort
      @ ~/work/Reactant.jl/Reactant.jl/src/Ops.jl:953 [inlined]
    [3] basic_sort
      @ ~/work/Reactant.jl/Reactant.jl/test/ops.jl:650 [inlined]
    [4] (::Main.var"##Shortcuts to MLIR ops#235".var"#basic_sort#24")(x::Reactant.TracedRArray{Float64, 3}, dimension::Int64)
      @ Reactant ./<missing>:0
    [5] basic_sort

Probably needs a rebase and an import perhaps?

[wsmoses]

gpu CI breaks, presumably due to not having an override for ConcreteRArray

Can you either mark it as allowscalar, or ideally add a permutedims override for ConcreteRArray

sort: Error During Test at /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/test/ops.jl:698
--
  | Test threw exception
  | Expression: if i == 1
  | sort(x)
  | else
  | sort(x; dims = j)
  | end == #= /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/test/ops.jl:698 =# @jit(basic_sort(x, j))
  | Scalar indexing is disallowed.
  | Invocation of getindex(::ConcreteRArray, ::Vararg{Int, N}) resulted in scalar indexing of a GPU array.
  | This is typically caused by calling an iterating implementation of a method.
  | Such implementations *do not* execute on the GPU, but very slowly on the CPU,
  | and therefore should be avoided.
  |  
  | If you want to allow scalar iteration, use `allowscalar` or `@allowscalar`
  | to enable scalar iteration globally or for the operations in question.
  | Stacktrace:
  | [1] error(s::String)
  | @ Base ./error.jl:35
  | [2] errorscalar(op::String)
  | @ GPUArraysCore ~/.cache/julia-buildkite-plugin/depots/0190ad31-dfb1-4a4c-ac5b-02d05277ba6c/packages/GPUArraysCore/GMsgk/src/GPUArraysCore.jl:155
  | [3] _assertscalar(op::String, behavior::GPUArraysCore.ScalarIndexing)
  | @ GPUArraysCore ~/.cache/julia-buildkite-plugin/depots/0190ad31-dfb1-4a4c-ac5b-02d05277ba6c/packages/GPUArraysCore/GMsgk/src/GPUArraysCore.jl:128
  | [4] assertscalar(op::String)
  | @ GPUArraysCore ~/.cache/julia-buildkite-plugin/depots/0190ad31-dfb1-4a4c-ac5b-02d05277ba6c/packages/GPUArraysCore/GMsgk/src/GPUArraysCore.jl:116
  | [5] getindex(::ConcreteRArray{Float64, 3}, ::Int64, ::Int64, ::Int64)
  | @ Reactant /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/src/ConcreteRArray.jl:241
  | [6] _getindex
  | @ ./abstractarray.jl:1340 [inlined]
  | [7] getindex
  | @ ./abstractarray.jl:1290 [inlined]
  | [8] _permutedims!(P::PermutedDimsArray{Float64, 3, (2, 1, 3), (2, 1, 3), ConcreteRArray{Float64, 3}}, src::ConcreteRArray{Float64, 3}, R1::CartesianIndices{0, Tuple{}}, R2::CartesianIndices{0, Tuple{}}, R3::CartesianIndices{1, Tuple{Base.OneTo{Int64}}}, ds::Int64, dp::Int64)
  | @ Base.PermutedDimsArrays ./permuteddimsarray.jl:261
  | [9] _copy!(P::PermutedDimsArray{Float64, 3, (2, 1, 3), (2, 1, 3), ConcreteRArray{Float64, 3}}, src::ConcreteRArray{Float64, 3})
  | @ Base.PermutedDimsArrays ./permuteddimsarray.jl:250
  | [10] permutedims!(dest::ConcreteRArray{Float64, 3}, src::ConcreteRArray{Float64, 3}, perm::Tuple{Int64, Int64, Int64})
  | @ Base.PermutedDimsArrays ./permuteddimsarray.jl:226
  | [11] permutedims(A::ConcreteRArray{Float64, 3}, perm::Tuple{Int64, Int64, Int64})
  | @ Base.PermutedDimsArrays ./permuteddimsarray.jl:145
  | [12] sort(A::ConcreteRArray{Float64, 3}; dims::Int64, alg::Base.Sort.MissingOptimization{Base.Sort.BoolOptimization{Base.Sort.Small{10, Base.Sort.InsertionSortAlg, Base.Sort.IEEEFloatOptimization{Base.Sort.IsUIntMappable{Base.Sort.Small{40, Base.Sort.InsertionSortAlg, Base.Sort.CheckSorted{Base.Sort.ComputeExtrema{Base.Sort.ConsiderCountingSort{Base.Sort.CountingSort, Base.Sort.ConsiderRadixSort{Base.Sort.RadixSort, Base.Sort.Small{80, Base.Sort.InsertionSortAlg, Base.Sort.ScratchQuickSort{Missing, Missing, Base.Sort.InsertionSortAlg}}}}}}}, Base.Sort.StableCheckSorted{Base.Sort.ScratchQuickSort{Missing, Missing, Base.Sort.InsertionSortAlg}}}}}}}, lt::Function, by::Function, rev::Nothing, order::Base.Order.ForwardOrdering, scratch::Nothing)
  | @ Base.Sort ./sort.jl:1796
  | [13] macro expansion
  | @ ~/.cache/julia-buildkite-plugin/julia_installs/bin/linux/x64/1.10/julia-1.10-latest-linux-x86_64/share/julia/stdlib/v1.10/Test/src/Test.jl:669 [inlined]
  | [14] macro expansion
  | @ /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/test/ops.jl:698 [inlined]
  | [15] macro expansion
  | @ ~/.cache/julia-buildkite-plugin/julia_installs/bin/linux/x64/1.10/julia-1.10-latest-linux-x86_64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
  | [16] top-level scope
  | @ /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/test/ops.jl:692
  | sort: Error During Test at /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/test/ops.jl:698
  | Test threw exception
  | Expression: if i == 1
  | sort(x)
  | else
  | sort(x; dims = j)
  | end == #= /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/test/ops.jl:698 =# @jit(basic_sort(x, j))
  | Scalar indexing is disallowed.
  | Invocation of getindex(::ConcreteRArray, ::Vararg{Int, N}) resulted in scalar indexing of a GPU array.
  | This is typically caused by calling an iterating implementation of a method.
  | Such implementations *do not* execute on the GPU, but very slowly on the CPU,
  | and therefore should be avoided.
  |  
  | If you want to allow scalar iteration, use `allowscalar` or `@allowscalar`
  | to enable scalar iteration globally or for the operations in question.
  | Stacktrace:
  | [1] error(s::String)
  | @ Base ./error.jl:35
  | [2] errorscalar(op::String)
  | @ GPUArraysCore ~/.cache/julia-buildkite-plugin/depots/0190ad31-dfb1-4a4c-ac5b-02d05277ba6c/packages/GPUArraysCore/GMsgk/src/GPUArraysCore.jl:155
  | [3] _assertscalar(op::String, behavior::GPUArraysCore.ScalarIndexing)
  | @ GPUArraysCore ~/.cache/julia-buildkite-plugin/depots/0190ad31-dfb1-4a4c-ac5b-02d05277ba6c/packages/GPUArraysCore/GMsgk/src/GPUArraysCore.jl:128
  | [4] assertscalar(op::String)
  | @ GPUArraysCore ~/.cache/julia-buildkite-plugin/depots/0190ad31-dfb1-4a4c-ac5b-02d05277ba6c/packages/GPUArraysCore/GMsgk/src/GPUArraysCore.jl:116
  | [5] getindex(::ConcreteRArray{Float64, 3}, ::Int64, ::Int64, ::Int64)
  | @ Reactant /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/src/ConcreteRArray.jl:241
  | [6] _getindex
  | @ ./abstractarray.jl:1340 [inlined]
  | [7] getindex
  | @ ./abstractarray.jl:1290 [inlined]
  | [8] _permutedims!(P::PermutedDimsArray{Float64, 3, (2, 3, 1), (3, 1, 2), ConcreteRArray{Float64, 3}}, src::ConcreteRArray{Float64, 3}, R1::CartesianIndices{0, Tuple{}}, R2::CartesianIndices{1, Tuple{Base.OneTo{Int64}}}, R3::CartesianIndices{0, Tuple{}}, ds::Int64, dp::Int64)
  | @ Base.PermutedDimsArrays ./permuteddimsarray.jl:261
  | [9] _copy!(P::PermutedDimsArray{Float64, 3, (2, 3, 1), (3, 1, 2), ConcreteRArray{Float64, 3}}, src::ConcreteRArray{Float64, 3})
  | @ Base.PermutedDimsArrays ./permuteddimsarray.jl:250
  | [10] permutedims!(dest::ConcreteRArray{Float64, 3}, src::ConcreteRArray{Float64, 3}, perm::Tuple{Int64, Int64, Int64})
  | @ Base.PermutedDimsArrays ./permuteddimsarray.jl:226
  | [11] permutedims(A::ConcreteRArray{Float64, 3}, perm::Tuple{Int64, Int64, Int64})
  | @ Base.PermutedDimsArrays ./permuteddimsarray.jl:145
  | [12] sort(A::ConcreteRArray{Float64, 3}; dims::Int64, alg::Base.Sort.MissingOptimization{Base.Sort.BoolOptimization{Base.Sort.Small{10, Base.Sort.InsertionSortAlg, Base.Sort.IEEEFloatOptimization{Base.Sort.IsUIntMappable{Base.Sort.Small{40, Base.Sort.InsertionSortAlg, Base.Sort.CheckSorted{Base.Sort.ComputeExtrema{Base.Sort.ConsiderCountingSort{Base.Sort.CountingSort, Base.Sort.ConsiderRadixSort{Base.Sort.RadixSort, Base.Sort.Small{80, Base.Sort.InsertionSortAlg, Base.Sort.ScratchQuickSort{Missing, Missing, Base.Sort.InsertionSortAlg}}}}}}}, Base.Sort.StableCheckSorted{Base.Sort.ScratchQuickSort{Missing, Missing, Base.Sort.InsertionSortAlg}}}}}}}, lt::Function, by::Function, rev::Nothing, order::Base.Order.ForwardOrdering, scratch::Nothing)
  | @ Base.Sort ./sort.jl:1796
  | [13] macro expansion
  | @ ~/.cache/julia-buildkite-plugin/julia_installs/bin/linux/x64/1.10/julia-1.10-latest-linux-x86_64/share/julia/stdlib/v1.10/Test/src/Test.jl:669 [inlined]
  | [14] macro expansion
  | @ /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/test/ops.jl:698 [inlined]
  | [15] macro expansion
  | @ ~/.cache/julia-buildkite-plugin/julia_installs/bin/linux/x64/1.10/julia-1.10-latest-linux-x86_64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
  | [16] top-level scope
  | @ /var/lib/buildkite-agent/builds/gpuci-15/julialang/reactant-dot-jl/test/ops.jl:692