Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Transpose emission for 0 rank tensor #375

Merged
merged 5 commits into from
Dec 20, 2024
Merged

No Transpose emission for 0 rank tensor #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91fdd05
`stablehlo.sort` Ops
glou-nes Dec 13, 2024
c55e9a5
do not transpose rank 0 tensor
glou-nes Dec 13, 2024
6c3abd8
Merge branch 'main' into transpose_simplify
glou-nes Dec 18, 2024
00cedb8
move check
glou-nes Dec 19, 2024
b91e069
format
glou-nes Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ext/ReactantCUDAExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,12 +335,6 @@ function link(job, compiled)
return compiled
end

function transpose_val(val)
attr = MLIR.IR.DenseArrayAttribute(
Int64[reverse(0:(length(size(MLIR.IR.type(val))) - 1))...]
)
return MLIR.IR.result(MLIR.Dialects.stablehlo.transpose(val; permutation=attr), 1)
end

Reactant.@reactant_overlay @noinline function (func::LLVMFunc{F,tt})(
args...;
Expand All @@ -366,7 +360,7 @@ Reactant.@reactant_overlay @noinline function (func::LLVMFunc{F,tt})(
Base.unsafe_pointer_to_objref(Base.reinterpret(Ptr{Cvoid}, a.ptr))::TracedRArray
push!(rarrays, ta)
arg = ta.mlir_data
arg = transpose_val(arg)
arg = Reactant.TracedUtils.transpose_val(arg)
push!(restys, MLIR.IR.type(arg))
push!(mlir_args, arg)
push!(
Expand Down Expand Up @@ -399,7 +393,7 @@ Reactant.@reactant_overlay @noinline function (func::LLVMFunc{F,tt})(
)
# call = MLIR.Dialects.stablehlo.custom_call(mlir_args; result_0=restys, call_target_name="reactant_gpu_call", output_operand_aliases, backend_config=MLIR.IR.Attribute(func.mod))
for (i, res) in enumerate(rarrays)
res.mlir_data = transpose_val(MLIR.IR.result(call, i))
res.mlir_data = Reactant.TracedUtils.transpose_val(MLIR.IR.result(call, i))
end

@show blockdim
Expand Down
6 changes: 3 additions & 3 deletions src/TracedUtils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,9 @@ function transpose_ty(mlirty)
return MLIR.IR.TensorType([reverse(size(mlirty))...], eltype(mlirty))
end
function transpose_val(val)
attr = MLIR.IR.DenseArrayAttribute(
Int64[reverse(0:(length(size(MLIR.IR.type(val))) - 1))...]
)
val_size = size(MLIR.IR.type(val))
val_size == () && return val
attr = MLIR.IR.DenseArrayAttribute(Int64[reverse(0:(length(val_size) - 1))...])
return MLIR.IR.result(MLIR.Dialects.stablehlo.transpose(val; permutation=attr), 1)
end

Expand Down
Loading