Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: testing using ReTestItems #56

Closed
wants to merge 3 commits into from
Closed

test: testing using ReTestItems #56

wants to merge 3 commits into from

Conversation

avik-pal
Copy link
Collaborator

@avik-pal avik-pal commented Jul 26, 2024

See https://github.com/JuliaTesting/ReTestItems.jl

The main benefits are

  • parallel testing (not super relevant for GH Actions since they are 2 core machines but helps a lot on the buildkite ones)
  • prevents stuff from spilling over to other files
  • loads Reactant and Test in every @testitem block automatically
  • lets you run specific tests locally by specifying name = ...

@avik-pal
Copy link
Collaborator Author

@wsmoses can you make the buildkite pipeline public?

Project.toml Outdated Show resolved Hide resolved
deps/ReactantExtra/make.jl Outdated Show resolved Hide resolved
@avik-pal avik-pal force-pushed the ap/cleaner_testing branch from f53e736 to bb11461 Compare July 27, 2024 17:12
@wsmoses
Copy link
Member

wsmoses commented Jul 27, 2024

@avik-pal pipeline should be public now

@mofeing
Copy link
Collaborator

mofeing commented Jul 28, 2024

@avik-pal I have a couple of questions:

  • does TestItems allow for some form of hierarchical organization like @testset?
  • the parallelization is thread- or process-based? if it's thread-based, @wsmoses do we know if XLA compilation is thread-safe?

@wsmoses
Copy link
Member

wsmoses commented Jul 28, 2024 via email

@avik-pal
Copy link
Collaborator Author

avik-pal commented Jul 28, 2024

does TestItems allow for some form of hierarchical organization like @testset?

ReTestItems' @testitem is a superset of the @testitem from TestItems.jl. Inside a @testitem you can have hierarchical @testsets. You can think of a @testitem as a module isolating the environment of the test.

the parallelization is thread- or process-based?

It is process-based.

One nice thing about it is that it lets a test crash julia without crashing the main test process.

@avik-pal avik-pal force-pushed the ap/cleaner_testing branch from bb11461 to 6d16643 Compare August 3, 2024 21:30
@avik-pal avik-pal force-pushed the ap/cleaner_testing branch from 6d16643 to 0c23681 Compare August 3, 2024 21:37
@avik-pal avik-pal closed this Sep 14, 2024
@avik-pal avik-pal deleted the ap/cleaner_testing branch September 14, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants