Remove deprecated pkg_resources #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilGirdhar
force-pushed
the
pkgre
branch
5 times, most recently
from
f4034a4
to
22cdca7
Compare
bouthilx
reviewed
Oct 10, 2023
|
Seems like there was an issue with the import here: https://github.com/Epistimio/orion/actions/runs/6471640548/job/17570730647?pr=1119#step:5:92 |
NeilGirdhar
force-pushed
the
pkgre
branch
7 times, most recently
from
a41d99c
to
5767a98
Compare
Fixed. |
|
Thanks! Now there seems to be an issue with the entry point object: https://github.com/Epistimio/orion/actions/runs/6486272775/job/17614328726?pr=1119#step:5:745 |
NeilGirdhar
force-pushed
the
pkgre
branch
2 times, most recently
from
1f08fa9
to
3d15289
Compare
Fixed. The Pylint error is because the Pylint you're running on 3.9 is too old IMO. Blocking that error is goign to be confusing since it's not an error in newer Pythons. |
|
@bouthilx Would you like me to do anything else for this pull request? |
NeilGirdhar
force-pushed
the
pkgre
branch
6 times, most recently
from
72a3fb4
to
b93b2ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests
$ tox -e py38; replace38by your Python version if necessary)Documentation
Quality
$ tox -e lint)Further comments
Please include any additional information or comment that you feel will be helpful to the review of this pull request.