Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HTTP constant URLs to Variables #1618

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ccuser44
Copy link
Contributor

This allows plugins to change them

@Dimenpsyonal Dimenpsyonal added ✨ enhancement Enhancing or improving existing functionality ⌛needs PoF This PR is awaiting proof of functionality labels Oct 13, 2024
@ccuser44
Copy link
Contributor Author

@Dimenpsyonal DOESN'T NEED POF!

@PurpleCreativity
Copy link
Contributor

needs PoF...

@Dimenpsyonal
Copy link
Member

needs pof

@ccuser44
Copy link
Contributor Author

ccuser44 commented Oct 14, 2024

PoF:

Variables.luau https://github.com/Epix-Incorporated/Adonis/pull/1618/files#diff-488D2F92EEBEC879EED6CB51CF9DC89BR68

Variables sets "HTTPCheckUrl" = "https://www.google.com/humans.txt" and "IPInfoUrl" = "https://ipinfo.io/json" and Variables is server.Variables

Players.luau https://github.com/Epix-Incorporated/Adonis/pull/1618/files#diff-2EA25E11A1E573CC77E389A67D932549L987

"https://ipinfo.io/json" is replaced with Variables.IPInfoUrl and Variables refers to server.Variables

HTTP.luau https://github.com/Epix-Incorporated/Adonis/pull/1618/files#diff-14A9ECC24BDA5D3CC48A782C81F602DDL46

"https://www.google.com/humans.txt" is replaced with Variables.HTTPCheckUrl and Variables refers to server.Variables

Server.luau

CORE_LOADING_ORDER loads Variables.luau before HTTP.luau and Players.luau so there is no loading order error

Hence the code works because there are no typos and the constants used for HTTP requests are the same as what is referred in Variables.luau AND no code modifies those values of Variables.luau

@ccuser44
Copy link
Contributor Author

@Dimenpsyonal

@ccuser44
Copy link
Contributor Author

The PoF: #1618 (comment)

@Dimenpsyonal Dimenpsyonal removed the ⌛needs PoF This PR is awaiting proof of functionality label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement Enhancing or improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants