Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse feature; getting columns from source; fix field name and table path #137

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gladkikhtutu
Copy link

Fixes:

  • getting column names from query sometimes not work, so we can get it from source.yml table description
  • for clickhouse join is not working so we need to point out join algorithm
  • in different databases you have only schema and no database name in table path, so node.database can be empty
  • count is popular word and it can be a field in initial query, so we need to use more specifit name

@cdiniz
Copy link
Collaborator

cdiniz commented May 26, 2023

Hi, @gladkikhtutu Thank you for your contribution.
We'll need to set up a Clickhouse environment in our CI/CD to be able to test this.
We'll try to tackle this soon.

@cdiniz cdiniz added the enhancement New feature or request label May 26, 2023
@cdiniz cdiniz temporarily deployed to test May 26, 2023 08:55 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants