Fix hiding of date range from filter params in multi-facet selection.

EreMaijala · Nov 20, 2024 · d20b634 · d20b634
1 parent b54a9b2
commit d20b634
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/themes/bootstrap3/js/facets.js b/themes/bootstrap3/js/facets.js
@@ -171,16 +171,16 @@ VuFind.register('multiFacetsSelection', function multiFacetsSelection() {
 
   // Make sure NOT to have a specific range filter parameter in the final URL
   function hideRangeFilterFromFinalUrl(rangeName) {
-    const paramStart = encodeURIComponent(rangeName + ':');
-    for (const [value] of initialParams.getAll('filter[]')) {
+    const paramStart = rangeName + ':';
+    for (const value of initialParams.getAll('filter[]')) {
       if (value.startsWith(paramStart)) {
-        globalRemovedParams.push(encodeURI('filter[]=' + value));
+        globalRemovedParams.append('filter[]', value);
         return;
       }
     }
-    for (const [value] of globalAddedParams.getAll('filter[]')) {
+    for (const value of globalAddedParams.getAll('filter[]')) {
       if (value.startsWith(paramStart)) {
-        globalAddedParams.remove('filter[]', value);
+        globalAddedParams.delete('filter[]', value);
       }
     }
   }

diff --git a/themes/bootstrap5/js/facets.js b/themes/bootstrap5/js/facets.js
@@ -171,16 +171,16 @@ VuFind.register('multiFacetsSelection', function multiFacetsSelection() {
 
   // Make sure NOT to have a specific range filter parameter in the final URL
   function hideRangeFilterFromFinalUrl(rangeName) {
-    const paramStart = encodeURIComponent(rangeName + ':');
-    for (const [value] of initialParams.getAll('filter[]')) {
+    const paramStart = rangeName + ':';
+    for (const value of initialParams.getAll('filter[]')) {
       if (value.startsWith(paramStart)) {
-        globalRemovedParams.push(encodeURI('filter[]=' + value));
+        globalRemovedParams.append('filter[]', value);
         return;
       }
     }
-    for (const [value] of globalAddedParams.getAll('filter[]')) {
+    for (const value of globalAddedParams.getAll('filter[]')) {
       if (value.startsWith(paramStart)) {
-        globalAddedParams.remove('filter[]', value);
+        globalAddedParams.delete('filter[]', value);
       }
     }
   }