-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wip/new service description format #21
Merged
alekodu
merged 17 commits into
EricssonResearch:main
from
salehsedghpour:feature/WIP/new_service_description_format
Mar 1, 2022
Merged
Feature/wip/new service description format #21
alekodu
merged 17 commits into
EricssonResearch:main
from
salehsedghpour:feature/WIP/new_service_description_format
Mar 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekodu
reviewed
Feb 25, 2022
alekodu
reviewed
Feb 25, 2022
alekodu
reviewed
Feb 25, 2022
alekodu
reviewed
Feb 25, 2022
alekodu
reviewed
Feb 25, 2022
alekodu
reviewed
Feb 25, 2022
alekodu
reviewed
Feb 25, 2022
alekodu
reviewed
Feb 25, 2022
alekodu
reviewed
Feb 25, 2022
@alekodu almost all issues are fixed right now, Please check it and if it works merge it |
alekodu
reviewed
Mar 1, 2022
alekodu
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
alekodu
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and ready for approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #6.
It could also help for other listed issues as well.
The old description and generated files are deleted. A new directory is created (input) and the new proposed description is listed there.
Also I created another
struct
for deployment with affinity.Configmaps are also updated. By merging this PR, the Services are not able to send and receive requests.