Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles are Back #67

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Subtitles are Back #67

merged 6 commits into from
Aug 8, 2023

Conversation

JokeBambi
Copy link
Contributor

also this is my first pull request and these are the only files i could find for the subtitles and code lines so dont blame me if i did something wrong

@charlesisfeline
Copy link
Contributor

when memehoovy adds an event system, maybe

@JokeBambi
Copy link
Contributor Author

JokeBambi commented Aug 8, 2023

when memehoovy adds an event system, maybe (noice)

hoping just hoping, well hoping events would be in haxe lol but character json would be also nice

@charlesisfeline
Copy link
Contributor

when memehoovy adds an event system, maybe (noice)

hoping just hoping, well hoping events would be in haxe lol but character json would be also nice

i tried softcoding characters in this engine tho

@JokeBambi
Copy link
Contributor Author

JokeBambi commented Aug 8, 2023

when memehoovy adds an event system, maybe (noice)

hoping just hoping, well hoping events would be in haxe lol but character json would be also nice

i tried softcoding characters in this engine tho

oh ig it wont work

@moxie-coder
Copy link
Collaborator

when memehoovy adds an event system, maybe

if Erizur allows it then sure

@moxie-coder
Copy link
Collaborator

there's still more that could be done here, but can be fixed/added after the merge tho

@moxie-coder moxie-coder merged commit b042e99 into Erizur:main Aug 8, 2023
3 checks passed
@moxie-coder
Copy link
Collaborator

thanks!

@JokeBambi
Copy link
Contributor Author

np

@charlesisfeline
Copy link
Contributor

when memehoovy adds an event system, maybe

if Erizur allows it then sure

personally, until the character json support is ready, i partially doubt it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants