Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] project_task_progress: add new module #17

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

Matthwhy
Copy link

@Matthwhy Matthwhy commented Jan 17, 2024

@Matthwhy Matthwhy force-pushed the 14.0-add-project_task_progress branch 2 times, most recently from 6ce1ab6 to 2b64722 Compare January 17, 2024 17:10
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16ab674) 91.39% compared to head (2351334) 91.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             14.0      #17      +/-   ##
==========================================
+ Coverage   91.39%   91.66%   +0.27%     
==========================================
  Files          17       20       +3     
  Lines         302      312      +10     
  Branches       44       46       +2     
==========================================
+ Hits          276      286      +10     
  Misses         17       17              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matthwhy Matthwhy force-pushed the 14.0-add-project_task_progress branch 5 times, most recently from 8e03f6d to ae3713e Compare January 17, 2024 17:51
@kaynnan kaynnan changed the title [ADD] project_task_progress: add new module [14.0][ADD] project_task_progress: add new module Jan 17, 2024
Copy link
Contributor

@kaynnan kaynnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

REVIEW [FUNCTIONAL AND CODE]

image

Obs: falta realizar as mudanças solicitadas anteriormente que deixei comentado nos arquivos.

@Matthwhy Matthwhy force-pushed the 14.0-add-project_task_progress branch from ae3713e to 476aaf4 Compare January 22, 2024 19:54
@Matthwhy Matthwhy requested a review from kaynnan January 22, 2024 19:59
Copy link
Contributor

@kaynnan kaynnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Matthwhy seu histórico de commit ficou errado, os commits deveriam estar com um --amend ao commit de [ADD].

Para corrigir, rode o comando: git rebase -i HEAD~3, você visualizará essa janela:

image

Note que nela há 3 commit seu com a palavra pick, nos dois ultimos troque por squash, isso fará com que os commits se juntem um ao outro, feito essa alteração pressiona CTRL + X, salva a alteração, em seguida você vai notar essa outra tela:

image

Você vai ter 3 mensagens de commit, deixe somente a primeira, as outras que foram Update README.rst, você realiza a exclusão ou coloca um # antes da frase, após os ajustes faça o push com o -f para forçar essas alterações.

@Matthwhy Matthwhy force-pushed the 14.0-add-project_task_progress branch from d78ec53 to 2351334 Compare January 24, 2024 19:19
Copy link

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants