Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor YAML Parsing and Management for Enhanced Readability and Maintainability #177

Closed
wants to merge 9 commits into from

Commits on Mar 16, 2024

  1. refactor(parser): decompose conditional for implicit document for ini…

    …tProductionTable method
    ramchaik committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    7a31a96 View commit details
    Browse the repository at this point in the history
  2. refactor(yaml-reader): rename variable anchors to anchorMap

    Makes the name more descriptive and readable.
    By reading the name you can tell it's a hashmap
    which was not clear previously.
    ramchaik committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    78d10cd View commit details
    Browse the repository at this point in the history
  3. refactor(yaml-reader): extract method readScalarValue from readValueI…

    …nternal
    
    Extract out the deserialization of scalar values to a new method.
    Make readValueInternal more modular
    ramchaik committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    fa1cfef View commit details
    Browse the repository at this point in the history
  4. refactor(yaml-reader): rename method valueConvertedNumber to parseNumber

    The method valueConvertedNumber has been renamed to parseNumber for improved clarity and consistency with naming conventions.
    
    Enhances the readability of the codebase and better reflects the purpose of the method, which is to parse a string value into a Number object.
    ramchaik committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    95dbdd5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9af34d4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0225ad6 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. refactor: extract YamlEntryManager class from YamlMapping

    - Extracted the YamlEntryManager class as a private inner class within YamlMapping to encapsulate logic related to managing YAML entries.
    - Enhances code organization and readability by isolating entry management functionality within its own class.
    - Improves modularity and maintainability by separating concerns within the YamlMapping class.
    - This refactoring adheres to the principle of encapsulation, ensuring that entry management is handled internally within the scope of YamlMapping.
    ramchaik committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    319aa85 View commit details
    Browse the repository at this point in the history
  2. refactor: replace conditional logic with polymorphism in YAML documen…

    …t reader
    
    - Implemented polymorphism to handle different YAML element types, enhancing code maintainability and extensibility.
    - Removed switch statements from readValue and readDocument methods, delegating to specific reader classes.
    - Introduced YamlElementReader interface and concrete implementations for each YAML element type.
    ramchaik committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6dd2680 View commit details
    Browse the repository at this point in the history
  3. refactor(YamlDocumentReader): move readSequenceElements to SequenceRe…

    …ader
    
    - Encapsulate sequence reading logic within SequenceReader for better organization.
    - Improve maintainability and readability of YamlDocumentReader by delegating sequence-specific operations.
    ramchaik committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7bddc22 View commit details
    Browse the repository at this point in the history