Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove as_ref on commitment #2892

Merged
merged 1 commit into from
Apr 4, 2024
Merged

remove as_ref on commitment #2892

merged 1 commit into from
Apr 4, 2024

Conversation

akonring
Copy link
Contributor

@akonring akonring commented Apr 3, 2024

@akonring akonring mentioned this pull request Apr 3, 2024
Open
@ggutoski
Copy link
Contributor

ggutoski commented Apr 4, 2024

Did you catch all occurrences of .as_ref().as_ref()? If so then we should merge this PR.

@akonring akonring marked this pull request as ready for review April 4, 2024 15:08
@akonring akonring merged commit 9298e10 into main Apr 4, 2024
17 checks passed
@akonring akonring deleted the ak/471 branch April 4, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparr721 jparr721 jparr721 approved these changes

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akonring @ggutoski @jparr721