This repository has been archived by the owner on May 23, 2022. It is now read-only.
Yeoman generator 1.0 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using promise on `this.prompt` per https://github.com/yeoman/generator/releases/tag/v0.23.0
we don't use any of these commands: https://github.com/yeoman/generator/releases/tag/v0.24.0 ... so looks like no code change necessary
moving towards es6 and using updated version of yeoman-generator syntax.
TravisCI is seeing the yarn lockfile, trying to use Yarn on the node v0.12 tests and failing. Although 0.12 should still work if you use NPM instead of yarn, I'm removing from our test configuration as it is now out of Node maintenance window: https://github.com/nodejs/LTS#lts-schedule
This was referenced Jan 6, 2017
This was referenced Jan 18, 2017
|
All tests pass locally, and I was able to download WAB (2.3 b/c I waited so long) and run on my Mac w/ no problems. Tested ES5/ES2015 widgets w/ default settings in 2D and 3D apps. Nice work @gavinr! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to
yeoman-generator1.0.1.Required changes:
this.promptper https://github.com/yeoman/generator/releases/tag/v0.23.0 (015c93c)gruntfile-editormanually as it does not come withyeoman-generatoranymorethis.fs.copyTpl()instead ofthis.template()yeoman-assert, andyeoman-test(needed for compatability with[email protected])Other minor changes:
const/letvariable names.widgetgenerator to be consistent with the app generator.chalk,yosayyarn.lockfileaddresses #77