Interactive legend: Re-calculate layer data when layer is off by default. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyhutchins
approved these changes
Jun 23, 2023
bcree11
reviewed
Jun 23, 2023
| export function getIntLegendLayerData(fLayer: __esri.FeatureLayer, data): IIntLegendLayerData { | ||
| return data?.[fLayer?.id]; | ||
| export function getIntLegendLayerData(fLayer: __esri.FeatureLayer): IIntLegendLayerData { | ||
| const data = interactiveLegendState?.data?.[fLayer?.id]; |
There was a problem hiding this comment.
This could be returned instead of creating a new variable and not doing anything with it. Also, the return type for this would have better checking if it was IIntLegendLayerData | undefined since that's what's actually being returned due to the optional chaining.
There was a problem hiding this comment.
Done.
Keeping the return type the same for now, changing it will affect other functions. Will address in the future when we're done patching.
bcree11
reviewed
Jun 23, 2023
| export function updateStore(data: IInteractiveLegendData, layerData?: { intLegendLayerData: IIntLegendLayerData; layerId: string }): void { | ||
| const layerId = layerData?.layerId; | ||
| export function updateStore(layerData: { intLegendLayerData: IIntLegendLayerData; layerId: string }): void { | ||
| const layerId = layerData?.layerId as string; |
There was a problem hiding this comment.
You could wrap all the lines in this function in an if statement if(layerData != null), then you wouldn't need the optional chaining. If layerId is undefined or null you wouldn't want to run store.set(…)
bcree11
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.