Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive Legend: Re-write how store is set to prevent overwrite #157

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Interactive Legend: Re-write how store is set to prevent overwrite #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ce2a2a
Update to 'Re-calculate layer data when layer is off by default' fix.
rslibed Jun 26, 2023
03b390e
fix changelog.md
rslibed Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v1.0.0-beta.97

### instant-apps-interactive-legend

- Fix: Update to "Re-calculate layer data when layer is off by default" fix.

## v1.0.0-beta.96

### instant-apps-interactive-legend
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"homepage": "https://esri.github.io/instant-apps-components",
"name": "@esri/instant-apps-components",
"version": "1.0.0-beta.96",
"version": "1.0.0-beta.97",
"description": "Reusable ArcGIS Instant Apps web components.",
"main": "dist/index.cjs.js",
"module": "dist/index.js",
Expand Down
4 changes: 2 additions & 2 deletions ...egend/instant-apps-interactive-legend-classic/instant-apps-interactive-legend-classic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ export class InstantAppsInteractiveLegendClassic {
() => !this.legendvm?.view?.updating,
async () => {
const data = await handleFeatureCount(this.legendvm, interactiveLegendState.data);
store.set("data", data);
store.set("data", {...interactiveLegendState.data, ...data});
this.calculatingFeatureCount = false;
},
{ once: true, initial: true },
Expand Down Expand Up @@ -811,7 +811,7 @@ export class InstantAppsInteractiveLegendClassic {
updateStore({ intLegendLayerData: dataForLayer, layerId: fLayer?.id });
if (this.featureCount) {
const data = await handleFeatureCount(this.legendvm, interactiveLegendState.data);
store.set("data", data);
store.set("data", {...interactiveLegendState.data, ...data});
}
}
}
Expand Down