Properties: Superseded PropertyValues by Elementa's States (concept) #46
+235
−104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A concept implementation for using Elementa's
State
objects for storing values of properties.I was inspired to do this PR from improving #25 . The ability to have multiple listeners/actions added in this PR would help getting that other PR ready.
Major changes in this PR:
PropertyValue
s become deprecated.PropertyValue#initialized
andPropertyValue#writeDataToFile
have been moved toPropertyData
PropertyCollector#getProperty
functions have been changed so that there would be less warnings caused by property values being deprecated.Vigilant#registerListener
functions were updated to use thePropertyCollector#getProperty
function to findPropertyData
instances. As a result,Vigilant#registerListener
functions can now find more properties (instead of only Java field backed ones) and that code is cleaner.All feedback is welcome. In the comments, I'll have a few things I especially want feedback on.