-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating ruby-version, refactoring ec_crypto_suite to support OpenSSL… #19
Conversation
… 3.0 and improve clarity
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 98.58% 99.88% +1.30%
==========================================
Files 46 46
Lines 2469 2588 +119
==========================================
+ Hits 2434 2585 +151
+ Misses 35 3 -32
☔ View full report in Codecov by Sentry. |
80177b3
to
2c9170f
Compare
3c7ce29
to
1dbdb94
Compare
@ZeroInputCtrl please review - I finished everything I wanted for this PR. We can cut a new release after we merge. |
0f19009
to
cfe10c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why here? Pretty sure the convention is to still use them as development dependencies in the gemspec.
Rubocop started complaining about it. https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecdevelopmentdependencies We can disable or modify that rubocop rule if we disagree. Most of my last changes were just to make rubocop happy. It looks like with the latest version, they've introduced several new rules. |
rubocop/rubocop#11469 here's the discussion on Gemfile vs gemspec. |
d2e31e1
to
5f51251
Compare
8c73714
to
399525c
Compare
Code Climate has analyzed commit f99691c and detected 0 issues on this pull request. View more on Code Climate. |
Updating library to latest version of ruby and refactoring ECCryptoSuite to support OpenSSL 3.0. Will need to most likely refactor again when ruby/openssl#555 gets merged and released in openssl gem.
Updated dependencies and test suite to support ruby 2.7, 3.0, 3.1, and 3.2. Should we consider dropping support for 2.7?