-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze transform_to_value #20
Merged
EugZol
merged 5 commits into
EugZol:master
from
mechnicov:bugfix-freeze-transformed-value
Jul 5, 2024
Merged
Freeze transform_to_value #20
EugZol
merged 5 commits into
EugZol:master
from
mechnicov:bugfix-freeze-transformed-value
Jul 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugZol
requested changes
Jul 5, 2024
README.md
Outdated
@@ -847,7 +847,7 @@ I18n keys: | |||
|
|||
#### `transform_to_value(value)` | |||
|
|||
Always returns ValidResult. The value is transformed to provided argument (disregarding the original value). See also [`default`](#defaultdefault_value-on-nil). | |||
Always returns ValidResult. The value is transformed to provided argument (disregarding the original value). Returned value deeply freezes with [`Ractor::make_shareable`](https://docs.ruby-lang.org/en/master/Ractor.html#method-c-make_shareable). See also [`default`](#defaultdefault_value-on-nil). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always returns ValidResult. The value is transformed to provided argument (disregarding the original value).
Returned value is deeply freezed with [`Ractor::make_shareable`](https://docs.ruby-lang.org/en/master/Ractor.html#method-c-make_shareable) to prevent application bugs due to modification of unintentionally shared value. If that effect is undesired, use [`transform { value }`](#transform--value--) instead.
See also [`default`](#defaultdefault_value-on-nil).
spec/datacaster_spec.rb
Outdated
|
||
expect(t.(123).to_dry_result).to eq Success("Test") | ||
it "becomes shareable" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this check is useful
EugZol
approved these changes
Jul 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR prevents bug when pass mutable object to
transform_to_value
. After these changes returned objects will become frozen