Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze transform_to_value #20

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

mechnicov
Copy link
Contributor

This MR prevents bug when pass mutable object to transform_to_value. After these changes returned objects will become frozen

README.md Outdated
@@ -847,7 +847,7 @@ I18n keys:

#### `transform_to_value(value)`

Always returns ValidResult. The value is transformed to provided argument (disregarding the original value). See also [`default`](#defaultdefault_value-on-nil).
Always returns ValidResult. The value is transformed to provided argument (disregarding the original value). Returned value deeply freezes with [`Ractor::make_shareable`](https://docs.ruby-lang.org/en/master/Ractor.html#method-c-make_shareable). See also [`default`](#defaultdefault_value-on-nil).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always returns ValidResult. The value is transformed to provided argument (disregarding the original value).

Returned value is deeply freezed with [`Ractor::make_shareable`](https://docs.ruby-lang.org/en/master/Ractor.html#method-c-make_shareable) to prevent application bugs due to modification of unintentionally shared value. If that effect is undesired, use [`transform { value }`](#transform--value--) instead.

See also [`default`](#defaultdefault_value-on-nil).

datacaster.gemspec Show resolved Hide resolved

expect(t.(123).to_dry_result).to eq Success("Test")
it "becomes shareable" do
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this check is useful

@mechnicov mechnicov requested a review from EugZol July 5, 2024 15:40
@EugZol EugZol merged commit 53fc688 into EugZol:master Jul 5, 2024
3 checks passed
@mechnicov mechnicov mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants