feat(#1): adds reference for createPayment #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 24, 2020 22:32
…nd introduces apiKey instead of access token
BramG
reviewed
Aug 5, 2020
BramG
reviewed
Aug 5, 2020
BramG
reviewed
Aug 5, 2020
| @@ -128,41 +227,40 @@ private function constructHeaders() | |||
| { | |||
| return [ | |||
| 'Content-Type: application/json', | |||
| 'Authorization: '.$this->access_token, | |||
| 'Authorization: ' . (!is_null($this->apiKey) ? $this->apiKey : $this->accessToken) | |||
There was a problem hiding this comment.
mixing apiKey and accessToken doesn't make it easier.
There was a problem hiding this comment.
The thing that I deprecated the accessToken but to be backwards compatible this mix is temporarily needed until a new major version is released and the accessToken is removed.
WillemStaels
reviewed
Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the reference parameter when creating a payment (#1). I also took the liberty to fix the naming of transaction_id to payment_id to make it consistent with the actual Payconiq API and did some refactoring as well to make the code more consistent overall.