Skip to content

Commit

Permalink
Remove @shopify/no-useless-computed-properties
Browse files Browse the repository at this point in the history
Use `"enforceForClassMembers": true` for `no-useless-computed-key` instead.
  • Loading branch information
EvgenyOrekhov committed Jun 9, 2024
1 parent 982a8d6 commit 27225f2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The most strict (yet practical) ESLint config.
Aims to include as many plugins and rules as possible to make your code
extremely consistent and robust.

**53 plugins. 1342 rules.**
**53 plugins. 1341 rules.**

## Usage

Expand Down Expand Up @@ -223,15 +223,14 @@ Base framework-agnostic config.
| [eslint-plugin-simple-import-sort](https://github.com/lydell/eslint-plugin-simple-import-sort) | 2 |
| [eslint-plugin-no-constructor-bind](https://github.com/markalfred/eslint-plugin-no-constructor-bind) | 1 |
| [eslint-plugin-no-unsanitized](https://github.com/mozilla/eslint-plugin-no-unsanitized) | 2 |
| [@shopify/eslint-plugin](https://github.com/Shopify/web-configs/tree/main/packages/eslint-plugin) | 1 |
| [eslint-plugin-no-use-extend-native](https://github.com/dustinspecker/eslint-plugin-no-use-extend-native) | 1 |
| [eslint-plugin-ext](https://github.com/jiangfengming/eslint-plugin-ext) | 1 |
| [eslint-plugin-no-only-tests](https://github.com/levibuzolic/eslint-plugin-no-only-tests) | 1 |
| [eslint-plugin-compat](https://github.com/amilajack/eslint-plugin-compat) | 1 |
| [eslint-plugin-json](https://github.com/azeemba/eslint-plugin-json)¹ | 1 |
| [eslint-plugin-yml](https://github.com/ota-meshi/eslint-plugin-yml)¹ | 1 |
| [eslint-plugin-toml](https://github.com/ota-meshi/eslint-plugin-toml)¹ | 1 |
| **Total:** | **645** |
| **Total:** | **644** |

¹ json/yml/toml plugins actually include several rules, but I consider each
plugin as a single "no-invalid" rule.
Expand Down
5 changes: 1 addition & 4 deletions base.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"no-constructor-bind",
"ext",
"putout",
"@shopify",
"regexp",
"@microsoft/sdl",
"no-unsanitized",
Expand Down Expand Up @@ -155,7 +154,7 @@
"no-useless-escape": "error",
"no-duplicate-imports": "error",
"no-unsafe-finally": "error",
"no-useless-computed-key": "error",
"no-useless-computed-key": ["error", { "enforceForClassMembers": true }],
"no-useless-rename": "error",
"max-lines": "error",
"no-template-curly-in-string": "error",
Expand Down Expand Up @@ -657,8 +656,6 @@
{ "exceptBetweenSingleLines": true }
],

"@shopify/no-useless-computed-properties": "error",

"regexp/match-any": "error",
"regexp/no-empty-capturing-group": "error",
"regexp/no-dupe-characters-character-class": "error",
Expand Down

0 comments on commit 27225f2

Please sign in to comment.