Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: set user password #4

Closed
wants to merge 6 commits into from
Closed

WIP: set user password #4

wants to merge 6 commits into from

Conversation

alias-rahil
Copy link

not tested yet

@alias-rahil alias-rahil linked an issue Oct 24, 2020 that may be closed by this pull request
Unable to login to ISO image #3
Open
EvilFreelancer
EvilFreelancer reviewed Oct 25, 2020
View reviewed changes
Copy link
Owner

@EvilFreelancer EvilFreelancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need turn off releases publication, because it's do nothing.

.github/workflows/release.yml Show resolved Hide resolved
book/chapter-6/6.6-create-essentials.sh Show resolved Hide resolved
docker-compose.yml.dist Outdated
@@ -12,4 +12,4 @@ services:
- ./tools:/lfs/tools
- ./lfs:/lfs
- ./dist:/dist
entrypoint: ["sleep", "inf"]
entrypoint: ["bash", "/book/book.sh"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, now need to find why it's not compiled and why ISO is empty :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, now need to find why it's not compiled and why ISO is empty :)

I will leave that upto you. Let me know when this is done so that I can complete the release script.

@alias-rahil
Copy link
Author

Just need turn off releases publication, because it's do nothing.

Yeah it is not complete yet. The script is intended to create a new github release after every push on master.

@alias-rahil
Copy link
Author

Things yet to be done:

  1. Fix compile errors and generating working iso image
  2. Complete the release script to create a github release after every push on master

@alias-rahil
Copy link
Author

Things yet to be done:

1. Fix compile errors and generating working iso image

2. Complete the release script to create a github release after every push on master

I will take care of the 2nd one.

@EvilFreelancer
Copy link
Owner

Okay, today ill check whats wrong with build stage, probably some small typo somewhere in scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilFreelancer EvilFreelancer EvilFreelancer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to login to ISO image
2 participants
@alias-rahil @EvilFreelancer