Skip to content

Commit

Permalink
Merge pull request #180 from Exabyte-io/update/SOF-7521
Browse files Browse the repository at this point in the history
update/SOF-7521 update: fix slab generation to expose more terminations
  • Loading branch information
VsevolodX authored Dec 19, 2024
2 parents 774de36 + 336f447 commit 8ca83f4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/cicd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [3.8.6]
python-version: [3.10.13]

steps:
- name: Checkout this repository
Expand All @@ -37,10 +37,10 @@ jobs:
strategy:
matrix:
python-version:
- 3.8.x
- 3.9.x
- 3.10.x
- 3.11.x
- 3.12.x
- 3.13.x

steps:
- name: Checkout this repository
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
- name: Publish python release
uses: ./actions/py/publish
with:
python-version: 3.8.x
python-version: 3.10.13
github-token: ${{ secrets.BOT_GITHUB_TOKEN }}
pypi-api-token: ${{ secrets.PYPI_API_TOKEN }}
publish-tag: 'false'
5 changes: 4 additions & 1 deletion src/py/mat3ra/made/tools/build/slab/builders.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ def _generate(self, configuration: _ConfigurationType) -> List[_GeneratedItemTyp
reorient_lattice=True,
primitive=configuration.make_primitive,
)
raw_slabs = generator.get_slabs()
raw_slabs = generator.get_slabs(
# We need to preserve symmetric slabs for different terminations at the surface
filter_out_sym_slabs=False,
)
self.__configuration = configuration

return [self.__conditionally_convert_slab_to_orthogonal_pymatgen(slab) for slab in raw_slabs]
Expand Down

0 comments on commit 8ca83f4

Please sign in to comment.