SOF-7051: replace SaveActionDialog with renderSaveActionDialog #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0stik
force-pushed
the
update/SOF-7051
branch
from
f0e7bc7 to
2669694
Compare
timurbazhirov
approved these changes
Nov 7, 2023
VsevolodX
reviewed
Nov 7, 2023
| disabled={!SaveActionDialog} | ||
| onClick={() => this.setState({ showSaveMaterialsDialog: true })} | ||
| > | ||
| <MenuItem disabled={!openSaveActionDialog} onClick={this.renderSaveActionDialog}> |
There was a problem hiding this comment.
The main idea I'm getting here is that you've changed rendering of the dialogs to happen only on call, not at every render of the parent component. So dialogs don't get mounted if not needed.
| /> | ||
| ) : null; | ||
| } | ||
| renderSaveActionDialog = () => { |
There was a problem hiding this comment.
Makes sense. Here the is provided in the openSaveactionDialog from the parent component in Web-App
k0stik
added a commit
that referenced
this pull request
Dec 1, 2023
SOF-7051: replace SaveActionDialog with renderSaveActionDialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.