Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WSL #435

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Add support for WSL #435

merged 2 commits into from
Sep 23, 2024

Conversation

VoxelPrismatic
Copy link
Contributor

For some reason, system("uname") returns an empty string. I added a check for this.

This also resolves #433

There are errors printed now, but that is from the server when unauthorized.

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024

CLA assistant check
All committers have signed the CLA.

@saranshsaini
Copy link
Contributor

Hey, just noticed that the check for mac is has('darwin') but the docs for the "has" function seem to use 'mac' ie. it should be has('mac'). Can you double check whether that is the case?

@saranshsaini
Copy link
Contributor

Thanks, looks good. One last thing, could you add a quick comment explaining why specifically this was necessary? Saw in your nvim config files that you were previously explicitly setting vim.g.codeium_os to "Linux" in your init.lua file. Does the change you made in this PR fix that (as in, do you still need to set the codeium_os explicitly in your init file)?

@VoxelPrismatic
Copy link
Contributor Author

Actually, I was looking through the code and tried setting that option to no avail. I just assumed I was setting it wrong and wanted to fix the code regardless.

@saranshsaini saranshsaini merged commit dfe75c6 into Exafunction:main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot authorize on Neovim
3 participants