Adding a dynamic stress (wave model) to wall_models

[ayalamanuel]

Summary

We have introduced a dynamic stress as a wall model. the dynamic stress calculates the stress due to waves. a new struct was implemented in ShearStressSimple.H where the wave stress is calculated. a new header (MOSD.H) was created with the calculations of the stress. the WallFunction.cpp has been modified accordingly.

Unit testing (test_mosd.cpp) and regression testing (channel_mosd.inp) using CPU has been done and added. The documentation of the model has also been added in the inputs_Boundary_conditions.rst file.

Pull request type

Please check the type of change introduced:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Checklist

The following is included:

• new unit-test(s)
• new regression test(s)
• documentation for new capability

This PR was tested by running:

• the unit tests
  • on GPU
  • on CPU
• the regression tests
  • on GPU
  • on CPU

Additional background

Issue Number:

[marchdf]

Quick list of things to do (I am sure you are working on these):

• documentation
• reg test
• unit test

I can look at the PR in detail later this week. Thank you for working on this!

[marchdf]

@ayalamanuel do you have any updates on this?

[ayalamanuel]

@marchdf Old files have been updated. Unit test, regression test and documentation have been added. Thanks!

[ayalamanuel]

I've made the modifications to all the comments made @marchdf

[marchdf]

hmmmm... I wonder if we don't want to make default arguments. So the get_shear would look like:

get_shear(amrex::Real u, amrex::Real wspd, amrex::Real u_dx=0, amrex::Real v_dx=0, amrex::Real x_c=0, amrex::Real unit_nor=0)

and then we don't have to specify these extra arguments. It's a hack around an API that needs to be updated to something better. Thoughts anyone?

[marchdf]

A meta comment here: to get past the CI check, the first thing you need to do is format your code. You can do that automatically with clang-format: https://exawind.github.io/amr-wind/developer/coding_guidelines.html#style-guide-recommendations