Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct parsing logic for ABLMeanBoussinesq #1244

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Sep 16, 2024

Summary

Previously, the read_temperature_profile input could be specified to "false" but would still be used. This is replaced with the following logic:

If read_temperature_profile is not in the input file, but tprofile_name is, then the temperature profile will be used. Alternatively, the temperature profile will not be used unless read_temperature_profile is present and true.

Any oppositions to this new approach?

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Need to run reg tests with ABLMeanBoussinesq

Issue Number: closes #1237

@marchdf marchdf self-requested a review September 16, 2024 20:20
@mbkuhn mbkuhn marked this pull request as ready for review September 16, 2024 20:22
@marchdf
Copy link
Contributor

marchdf commented Sep 16, 2024

Tests pass.

@mbkuhn mbkuhn merged commit e26eb80 into Exawind:main Sep 16, 2024
15 checks passed
@mbkuhn mbkuhn deleted the mean_boussinesq_parse branch September 24, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contradictory input file behavior possible for ABLMeanBoussinesq
2 participants