Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU segfault introduced in #1066 #1247

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix GPU segfault introduced in #1066 #1247

merged 2 commits into from
Sep 17, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Sep 17, 2024

Summary

Fix GPU segfault introduced in #1066. The code is using the device data of bcrec. It should be using the host version. @mukul1992 would you mind letting me know if you disagree?

This should fix:

  • freestream_godunov_inout

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Closes #1246

@marchdf marchdf marked this pull request as ready for review September 17, 2024 17:57
@marchdf marchdf enabled auto-merge (squash) September 17, 2024 19:43
@marchdf marchdf merged commit f9fd2b3 into Exawind:main Sep 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault on GPU in freestream_godunov_inout
2 participants