Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling volume #959

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Sampling volume #959

merged 7 commits into from
Jan 22, 2024

Conversation

tonyinme
Copy link
Contributor

This is a feature to sample a 3d volume. This feature allows to sample a small part of the domain at a certain resolution and can be used for post-processing.

@tonyinme tonyinme requested a review from mbkuhn January 17, 2024 17:11
@marchdf
Copy link
Contributor

marchdf commented Jan 17, 2024

Would you mind adding a unit test? We have some examples in things like test_sampling.cpp.

@tonyinme
Copy link
Contributor Author

Thanks @marchdf ! I addressed your fixes in the latest commit.

@marchdf
Copy link
Contributor

marchdf commented Jan 17, 2024

Thanks for adding the unit test. Would you mind also adding a regression test so that it shows how this can be used?

@tonyinme
Copy link
Contributor Author

@marchdf , I pushed the changes you requested.
Let me know if we need any other changes.

@marchdf
Copy link
Contributor

marchdf commented Jan 18, 2024

Awesome. There's just one small CI clang-tidy warning to fix ;)

@tonyinme tonyinme merged commit 306b306 into Exawind:main Jan 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbkuhn mbkuhn mbkuhn approved these changes

@marchdf marchdf marchdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyinme @marchdf @mbkuhn