-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADM Turbine Level Search #1266
base: master
Are you sure you want to change the base?
ADM Turbine Level Search #1266
Conversation
… check before evaluating exponentials
Hi @gyalla, do you think this is close to being able to merge? It looks like you addressed all the outstanding comments. |
Hi @marchdf , thanks for following up on this. I still have a few to-do's on this PR so I can close it for now and re-open it once I check those off. I do need the NREL5MW actuator line/disk regression tests working before I can confidently validate this code. I see you have a PR related to those tests -- does that mean they are close to working again? |
Oh if you still have things going on, feel free to keep it open. Re: the tests. I do have those working! But I need to move the pinned dev openfast commit we have in exawind-manager. Then I will merge my PR. Maybe I can do that today. |
@gyalla got everything merged in! So those tests should pass now. |
Hi Phil,
The question is regarding the line
auto points = pointCentroid_.template view<ActuatorFixedMemSpace>();
in ActuatorBulk.C and why it does not work when replacing pointCentroid_ with hubLocations_ as in
auto points = hubLocations_.template view<ActuatorFixedMemSpace>();
Best,
Gopal