Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM Turbine Level Search #1266

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

gyalla
Copy link

@gyalla gyalla commented Jun 13, 2024

Hi Phil,

The question is regarding the line
auto points = pointCentroid_.template view<ActuatorFixedMemSpace>();
in ActuatorBulk.C and why it does not work when replacing pointCentroid_ with hubLocations_ as in
auto points = hubLocations_.template view<ActuatorFixedMemSpace>();

Best,
Gopal

src/aero/actuator/ActuatorBulkFAST.C Outdated Show resolved Hide resolved
src/aero/actuator/ActuatorBulkFAST.C Outdated Show resolved Hide resolved
src/aero/actuator/ActuatorExecutorsFASTNgp.C Outdated Show resolved Hide resolved
include/aero/actuator/ActuatorBulk.h Outdated Show resolved Hide resolved
@marchdf
Copy link
Contributor

marchdf commented Oct 28, 2024

Hi @gyalla, do you think this is close to being able to merge? It looks like you addressed all the outstanding comments.

@gyalla
Copy link
Author

gyalla commented Nov 4, 2024

Hi @gyalla, do you think this is close to being able to merge? It looks like you addressed all the outstanding comments.

Hi @marchdf , thanks for following up on this. I still have a few to-do's on this PR so I can close it for now and re-open it once I check those off. I do need the NREL5MW actuator line/disk regression tests working before I can confidently validate this code. I see you have a PR related to those tests -- does that mean they are close to working again?

@marchdf
Copy link
Contributor

marchdf commented Nov 4, 2024

Oh if you still have things going on, feel free to keep it open.

Re: the tests. I do have those working! But I need to move the pinned dev openfast commit we have in exawind-manager. Then I will merge my PR. Maybe I can do that today.

@marchdf
Copy link
Contributor

marchdf commented Nov 4, 2024

@gyalla got everything merged in! So those tests should pass now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants