Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Twitter icon, strings and update icons #325

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Update Twitter icon, strings and update icons #325

merged 4 commits into from
Sep 15, 2023

Conversation

Jean-BaptisteC
Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC commented Aug 11, 2023 •
edited
Loading

Before After

@codeurimpulsif
Copy link
Contributor

Also, do you think it's a good idea to change this now? Everyone seem to still refer to this social network as "Twitter"

@Jean-BaptisteC
Copy link
Contributor Author

Next version is not planned for now (September or October, maybe).
I think a most of users know new name of Twitter, if you want, i keep new icon with older name ?

@codeurimpulsif
Copy link
Contributor

I don't know, maybe we can speak about this at the next meeting?

@Jean-BaptisteC
Copy link
Contributor Author

I have found a better way, I suggest for Twitter string X (Twitter)

@Jean-BaptisteC
Copy link
Contributor Author

I have rollback translations
PTAL

@Jean-BaptisteC Jean-BaptisteC changed the title Update X icons, strings and update icons Update Twitter icons, strings and update icons Aug 19, 2023
@Jean-BaptisteC Jean-BaptisteC changed the title Update Twitter icons, strings and update icons Update Twitter icon, strings and update icons Aug 20, 2023
@Jean-BaptisteC Jean-BaptisteC merged commit 3ca5ef1 into master Sep 15, 2023
1 check passed
@Jean-BaptisteC Jean-BaptisteC deleted the twitter branch September 15, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeurimpulsif codeurimpulsif codeurimpulsif approved these changes

@jfoucry jfoucry Awaiting requested review from jfoucry

@Porkepix Porkepix Awaiting requested review from Porkepix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Twitter icons and translations
2 participants
@Jean-BaptisteC @codeurimpulsif