Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve layout on App report #341

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Improve layout on App report #341

merged 2 commits into from
Dec 8, 2023

Conversation

Jean-BaptisteC
Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC commented Sep 19, 2023 •
edited
Loading

This PR update:

  • Increase margin on app title
  • Increase margin on app versions
  • Update which textviews are visible, now if app version name and report version name are the same (but version codes are different), we show only one version

@Jean-BaptisteC Jean-BaptisteC mentioned this pull request Oct 5, 2023
Closed
ghost
ghost approved these changes Dec 8, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Jean-BaptisteC Jean-BaptisteC merged commit 4cdbca5 into master Dec 8, 2023
1 check passed
@Jean-BaptisteC Jean-BaptisteC deleted the improve_appdetail branch December 8, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jean-BaptisteC