Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove name and firstname from API key creation #602

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: Remove name and firstname from API key creation #602

merged 1 commit into from
Jan 18, 2024

Conversation

pnu-s
Copy link
Member

@pnu-s pnu-s commented Jan 17, 2024

Removing the need of name and first name during API key creation

I'll make a separate oneshot script in order to remove the data from the production DB

U039b
U039b approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@U039b U039b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @pnu-s!

codeurimpulsif
codeurimpulsif approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, seems ok for me. Thanks!

@pnu-s pnu-s merged commit 4069aad into v1 Jan 18, 2024
8 checks passed
@pnu-s pnu-s deleted the api_names branch January 18, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@U039b U039b U039b approved these changes

@codeurimpulsif codeurimpulsif codeurimpulsif approved these changes

Assignees

@codeurimpulsif codeurimpulsif

@U039b U039b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnu-s @codeurimpulsif @U039b