fix typo

ExpediaGroup · Oct 15, 2024 · bbdc538 · bbdc538
1 parent d828b36
commit bbdc538
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 26 deletions.
diff --git a/k8s-readonly.tf b/k8s-readonly.tf
@@ -370,18 +370,9 @@ resource "kubernetes_pod_disruption_budget" "hms_readonly" {
       }
     }
 
-    dynamic "max_unavailable" {
-      for_each = var.hms_ro_k8s_pdb_settings.max_unavailable != null ? [var.hms_ro_k8s_pdb_settings.max_unavailable] : ["1"]
-      content {
-        max_unavailable = var.hms_ro_k8s_pdb_settings.max_unavailable != null ? var.hms_ro_k8s_pdb_settings.max_unavailable : "1"
-      }
-    }
-
-    dynamic "min_available" {
-      for_each = var.hms_ro_k8s_pdb_settings.min_available != null ? [var.hms_ro_k8s_pdb_settings.min_available] : []
-      content {
-        min_available = var.hms_ro_k8s_pdb_settings.min_available
-      }
-    }
+    # Conditionally use min_available or max_unavailable
+    # set max_unavailable to 1 by default if PDB is created
+    max_unavailable = var.hms_ro_k8s_pdb_settings.max_unavailable != null ? var.hms_ro_k8s_pdb_settings.max_unavailable : "1"
+    min_available   = var.hms_ro_k8s_pdb_settings.min_available != null ? var.hms_ro_k8s_pdb_settings.min_available : null
   }
 }
diff --git a/k8s-readwrite.tf b/k8s-readwrite.tf
@@ -388,18 +388,9 @@ resource "kubernetes_pod_disruption_budget" "hms_readwrite" {
       }
     }
 
-    dynamic "max_unavailable" {
-      for_each = var.hms_rw_k8s_pdb_settings.max_unavailable != null ? [var.hms_rw_k8s_pdb_settings.max_unavailable] : ["1"]
-      content {
-        max_unavailable = var.hms_rw_k8s_pdb_settings.max_unavailable
-      }
-    }
-
-    dynamic "min_available" {
-      for_each = var.hms_rw_k8s_pdb_settings.min_available != null ? [var.hms_rw_k8s_pdb_settings.min_available] : []
-      content {
-        min_available = var.hms_rw_k8s_pdb_settings.min_available
-      }
-    }
+    # Conditionally use min_available or max_unavailable
+    # set max_unavailable to 1 by default if PDB is created
+    max_unavailable = var.hms_rw_k8s_pdb_settings.max_unavailable != null ? var.hms_rw_k8s_pdb_settings.max_unavailable : "1"
+    min_available   = var.hms_rw_k8s_pdb_settings.min_available != null ? var.hms_rw_k8s_pdb_settings.min_available : null
   }
 }