feat: make builder use null graphQLContext if null was provided (#1607)

ExpediaGroup · Dec 6, 2022 · a059442 · a059442
1 parent a057368
commit a059442
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...in-server/src/main/kotlin/com/expediagroup/graphql/server/extensions/requestExtensions.kt b/...in-server/src/main/kotlin/com/expediagroup/graphql/server/extensions/requestExtensions.kt
@@ -36,7 +36,7 @@ fun GraphQLRequest.toExecutionInput(
         .extensions(this.extensions ?: emptyMap())
         .dataLoaderRegistry(dataLoaderRegistry ?: KotlinDataLoaderRegistry())
         .also { builder ->
-            graphQLContext?.let { builder.context(it) }
+            builder.context(graphQLContext)
             graphQLContextMap?.let { builder.graphQLContext(it) }
         }
         .build()

diff --git a/...ver/src/test/kotlin/com/expediagroup/graphql/server/extensions/RequestExtensionsKtTest.kt b/...ver/src/test/kotlin/com/expediagroup/graphql/server/extensions/RequestExtensionsKtTest.kt
@@ -24,6 +24,7 @@ import org.dataloader.DataLoader
 import org.junit.jupiter.api.Test
 import kotlin.test.assertEquals
 import kotlin.test.assertNotNull
+import kotlin.test.assertNull
 import kotlin.test.assertTrue
 
 class RequestExtensionsKtTest {
@@ -80,6 +81,7 @@ class RequestExtensionsKtTest {
 
         val executionInput = request.toExecutionInput(graphQLContextMap = context)
         assertEquals(1, executionInput.graphQLContext.get("foo"))
+        assertNull(executionInput.context)
     }
 
     @Test