Rewrite CompletableFutureExtension.allSettled to not use CompletableFuture.supplyAsync #1872
+4
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelAndalon
approved these changes
Oct 23, 2023
dariuszkuc
reviewed
Oct 23, 2023
...tlin/com/expediagroup/graphql/generator/federation/extensions/CompletableFutureExtensions.kt
Outdated
Show resolved
Hide resolved
…uture.supplyAsync
roookeee
force-pushed
the
avoid_future_nesting_all_settled
branch
from
f203c30 to
ae902e6
Compare
|
Could we get a bugfix release that includes this change in the near future? It's currently blocking our prod migration to graphql-kotlin 7.x because of performance regressions. Thank you! |
|
I'll try getting two federation fixes in over the weekend (unsure why builds time out on those) and we should be able to release afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a big drop in performance after switching to the new
CompletableFuturebasedFederatedTypeResolver. Our investigations led us to the implementation ofCompletableFutureExtension.allSettledwhich has the following issues:CompletableFuture.supplyAsyncwhich looses all thread local data (as we switch to another thread pool we have no control over), which breaks most tracing frameworks and all other thread local usagesthenApplyandexceptionallywork without nesting of futures. This avoids non-neglegible overheadI changed the accompanying test to expect another exception type as only
get()throw aExecutionException. This should not affect your public API as its an internal method and I could not find any other references toExecutionExceptioningraphql-kotlins codebase.