fix: Use local Onyx key to throttle location permission prompts. #48237

Krishna2323 · 2024-08-29T06:32:08Z

Details

Fixed Issues

$ #47800
PROPOSAL: #47800 (comment)

Tests

Click FAB > Submit expense > Select scan tab
Upload a receipt > Select a participant > Submit
Select Not now in allow location modal
Repeat step 1 & 2 and verify allow location modal is not shown again

Verify that no errors appear in the JS console

Offline tests

Click FAB > Submit expense > Select scan tab
Upload a receipt > Select a participant > Submit
Select Not now in allow location modal
Repeat step 1 & 2 and verify allow location modal is not shown again

QA Steps

Click FAB > Submit expense > Select scan tab
Upload a receipt > Select a participant > Submit
Select Not now in allow location modal
Repeat step 1 & 2 and verify allow location modal is not shown again

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: krishna2323 <[email protected]>

melvin-bot · 2024-08-29T06:32:14Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2024-09-02T11:37:36Z

Will provide update today.

Krishna2323 · 2024-09-03T03:41:32Z

@Julesssss @shubham1206agra, sorry for delay, I'm not sure what should we do with the permission prompt on the scan request page.

I'm confused because if we don't get the current location using getCurrentPosition when the modal prompt has already been shown, we won't get the location even if the user has allowed location access. In my opinion (IMO), we shouldn't do anything for this page because if the user has denied it, the prompt will not be shown again afterward.

shubham1206agra · 2024-09-03T04:00:40Z

Sorry @Krishna2323, I don't follow you.

Can you elaborate the comment?

Krishna2323 · 2024-09-03T04:40:39Z

@shubham1206agra, when we create a scan request through Quick action, the confirmation step is skipped, and we directly call getCurrentPosition. This triggers the default location permission prompt if it hasn’t been shown before or if the permission is set to "Allow once."

In this case, we shouldn't hide the prompt if the confirmation page prompt has already been shown. This is because if we don’t call getCurrentPosition, the coordinates won’t be sent to the backend, even if location permission has been granted. I hope you understand this 😅. it also took me some time to understand the flow.

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Line 269 in f7d8e48

getCurrentPosition(

shubham1206agra · 2024-09-03T04:48:44Z

@shubham1206agra, when we create a scan request through Quick action, the confirmation step is skipped, and we directly call getCurrentPosition. This triggers the default location permission prompt if it hasn’t been shown before or if the permission is set to "Allow once."

In this case, we shouldn't hide the prompt if the confirmation page prompt has already been shown. This is because if we don’t call getCurrentPosition, the coordinates won’t be sent to the backend, even if location permission has been granted. I hope you understand this 😅. it also took me some time to understand the flow.

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Line 269 in f7d8e48

getCurrentPosition(

If the permission is denied by the user in the modal, then we skip showing the modal for a week, no matter where it was about to show.

Julesssss · 2024-09-03T08:14:03Z

when we create a scan request through Quick action, the confirmation step is skipped, and we directly call getCurrentPosition

I think I understand. So because of the simpler flow we don't show our custom permission prompt before the native permission is requested?

In this case, we shouldn't hide the prompt if the confirmation page prompt has already been shown.

I think this is a bit confusing because we have both the custom prompt, and the native prompt. If we have already shown the custom prompt, and users accepted, we wouldn't need to show it again anyway, right?

Krishna2323 · 2024-09-04T04:35:06Z

I think this is a bit confusing because we have both the custom prompt, and the native prompt. If we have already shown the custom prompt, and users accepted, we wouldn't need to show it again anyway, right?

Yes, if the location access was granted or denied, the native prompt won't be shown again, it will just give the cords and proceed.

Julesssss · 2024-09-04T08:57:55Z

Yes, if the location access was granted or denied, the native prompt won't be shown again, it will just give the cords and proceed.

So are we not able to stop calling getLocation... when we know location permission hasn't been given?

Krishna2323 · 2024-09-06T12:37:52Z

So are we not able to stop calling getLocation... when we know location permission hasn't been given?

I think we can. I will try to understand the flow better and respond here soon.

Krishna2323 · 2024-09-09T04:11:16Z

@Julesssss @shubham1206agra, sorry for the delay 🙏🏻. I've been sick for the last three days 🤧.

Let's try to understand the flow better:

Scenario 1 - Location permission is unset (neither denied nor allowed)

The user starts an IOU request flow with a receipt and proceeds to the confirmation page.
When the user presses the submit button, our custom modal pops up.
If the user selects Continue, the native permission prompt will appear with three options: Allow once, Allow while using the app, and Don't Allow.
If the user selects either Allow while using the app or Don't Allow, the native permission prompt will not be shown again in any case (neither in Quick action flow nor in the regular one).
At this point, since our custom modal has already been shown on the confirmation page, it will not be displayed again unless a week has passed.

Scenario 2 - Location permission is unset (neither denied nor allowed)

The user starts an IOU request flow with a receipt and proceeds to the confirmation page.
When the user presses the submit button, our custom permission modal pops up.
If the user selects Not now on the custom permission modal, the modal will close and the request will be submitted.
Since the user selected Not now, the permission status remains unset (unknown to the device).
If the user later starts a scan request using the Quick Action flow and tries to submit the expense, the native permission prompt will appear, offering the same three options: Allow once, Allow while using the app, and Don't Allow.
If the user selects either Allow while using the app or Don't Allow, the native permission prompt will not be shown again in any case.
As in Scenario 1, since our custom modal was already shown on the confirmation page, it will not be displayed again unless a week has passed.

Scenario 3 - Location permission is unset (neither denied nor allowed)

Similar to the flow above, if the user selects Allow once, the native prompt will be shown every time the user restarts the app and goes through the Quick Action scan flow.
Our custom modal will not been shown unless a week has been passed.

IMO, what we have now (above scenarios) is the correct, but let me know if you think otherwise.

Result with current implementation (Changes in this PR)

geolocation_permission_flow.1.mp4

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Julesssss · 2024-09-09T10:22:28Z

Similar to the flow above, if the user selects Allow once, the native prompt will be shown every time the user restarts the app and goes through the Quick Action scan flow.

Thank you for the detailed notes. It's a bit of an edge case given that users must select yes to our prompt, but once to the iOS prompt (and only occurs on iOS). However, it does suck that our quick flow is blocked by the annoying iOS prompt.

@shubham1206agra if it was possible to disable the check entirely for the quick action iOS flow with a unique param, I think that would be preferable. I'm going to share this for additional thoughts in the issue.

Alternatively, do we get a response from the iOS permission (getLocation) request? Are we able to detect the users choice? If we could detect users who have selected 'Only Once' that would be ideal, but I fear this is going to be unlikely.

shubham1206agra · 2024-09-09T10:36:52Z

@Krishna2323 Please see above comment.

Julesssss · 2024-09-09T10:42:48Z

Ah yes sorry, I meant to tag you @Krishna2323 -- I looked at reviewers 🤦

Julesssss · 2024-09-10T15:20:11Z

Hey @Krishna2323. let's move forward with the known iOS issue where the prompt occurs in the quick action flow 👍

Krishna2323 · 2024-09-10T21:40:40Z

Hey @Krishna2323. let's move forward with the known iOS issue where the prompt occurs in the quick action flow 👍

I think we can move forward with the current changes then, I will update the checklist tomorrow.

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-09-11T21:19:29Z

@shubham1206agra, you can start reviewing this.

…true. Signed-off-by: krishna2323 <[email protected]>

Julesssss

Looking good.

Julesssss · 2024-09-16T08:59:04Z

@shubham1206agra ready for a second review when you have time

shubham1206agra · 2024-09-16T09:11:36Z

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

-                            onGrant={() => createTransaction(selectedParticipantList, true)}
-                            onDeny={() => createTransaction(selectedParticipantList, false)}
+                            onGrant={() => {
+                                IOU.updateLastLocationPermissionPrompt();


@Krishna2323 Why should I set the permission key on Granting access?

Because if the user disables the permission from setting after granting, we will be showing the permission modal again.

shubham1206agra · 2024-09-18T01:15:26Z

@Krishna2323 I asked you a question in slack btw.

Krishna2323 · 2024-09-18T07:08:16Z

@shubham1206agra, I'm not in the open-source channel 😔

shubham1206agra · 2024-09-18T07:12:41Z

@shubham1206agra, I'm not in the open-source channel 😔

@Krishna2323 I see you in slack. Please check again

Krishna2323 · 2024-09-18T07:23:27Z

@shubham1206agra,

Julesssss · 2024-09-18T09:54:14Z

I can also see you in Slack under this email:

github-actions · 2024-09-18T10:30:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48237/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48237/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48237/NewExpensify.dmg	https://48237.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Krishna2323 · 2024-09-18T11:05:52Z

Yayy🎉...that's weird, I can't access the channel through mobile app but I have access on the desktop app.

Krishna2323 · 2024-09-19T09:06:35Z

I had a discussion with @shubham1206agra on Slack. We need to test one more case before we can proceed. I will test and provide information about that today

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-09-20T09:35:58Z

Thanks for pointing out the bug, @shubham1206agra. You meant to say that if we set the Onyx key to not show the permission modal on onGrant, the location will not be fetched for the second time because of the locationPermissionGranted check here, right? I have removed IOU.updateLastLocationPermissionPrompt(); from onGrant callback.

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 497 to 498 in 4c9a3fb

    
           // If the transaction amount is zero, then the money is being requested through the "Scan" flow and the GPS coordinates need to be included. 
        
           if (transaction.amount === 0 && !isSharingTrackExpense && !isCategorizingTrackExpense && locationPermissionGranted) {

Krishna2323 · 2024-09-24T19:54:09Z

@shubham1206agra friendly bump.

Krishna2323 · 2024-10-01T04:28:04Z

@shubham1206agra, bump ^

shubham1206agra · 2024-10-01T04:36:18Z

@Krishna2323 Please resolve conflicts

Krishna2323 · 2024-10-01T04:49:40Z

done.

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

shubham1206agra · 2024-10-03T11:36:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-10-03.at.4.40.35.PM.mov

iOS: Native

Screen.Recording.2024-10-03.at.4.56.38.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-03.at.4.21.06.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-03.at.4.17.47.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-03.at.4.46.19.PM.mov

Signed-off-by: krishna2323 <[email protected]>

fix: Use local Onyx key to throttle location permission prompts.

fbaec00

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 requested a review from a team as a code owner August 29, 2024 06:32

melvin-bot bot requested a review from shubham1206agra August 29, 2024 06:32

Krishna2323 marked this pull request as draft August 29, 2024 06:32

melvin-bot bot removed the request for review from a team August 29, 2024 06:32

Merge branch 'Expensify:main' into krishna2323/issue/47800

b049b42

Merge branch 'Expensify:main' into krishna2323/issue/47800

fbfc000

Julesssss reviewed Sep 9, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated Show resolved Hide resolved

Julesssss mentioned this pull request Sep 9, 2024

[$250] Use local Onyx key to throttle location permission prompts #47800

Open

6 tasks

Merge branch 'main' into krishna2323/issue/47800

2239560

Krishna2323 marked this pull request as ready for review September 11, 2024 21:13

minor fix.

8a26363

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'main' into krishna2323/issue/47800

cd61aa9

calculate shouldStartLocationPermissionFlow only when gpsRequired is …

e5f2df5

…true. Signed-off-by: krishna2323 <[email protected]>

Julesssss reviewed Sep 16, 2024

View reviewed changes

shubham1206agra reviewed Sep 16, 2024

View reviewed changes

Julesssss added the Ready To Build label Sep 18, 2024

Krishna2323 added 2 commits September 20, 2024 05:10

Merge branch 'Expensify:main' into krishna2323/issue/47800

d225988

minor update.

2b10015

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'main' into krishna2323/issue/47800

8a15b48

shubham1206agra reviewed Oct 3, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated Show resolved Hide resolved

shubham1206agra reviewed Oct 3, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated Show resolved Hide resolved

shubham1206agra approved these changes Oct 3, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss October 3, 2024 11:36

Krishna2323 added 3 commits October 3, 2024 21:35

Merge branch 'Expensify:main' into krishna2323/issue/47800

c4ccc77

minor improvements.

1530d59

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'main' into krishna2323/issue/47800

c43e536

fix: Use local Onyx key to throttle location permission prompts. #48237

Are you sure you want to change the base?

fix: Use local Onyx key to throttle location permission prompts. #48237

Conversation

Krishna2323 commented Aug 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 29, 2024

Krishna2323 commented Sep 2, 2024

Krishna2323 commented Sep 3, 2024

shubham1206agra commented Sep 3, 2024

Krishna2323 commented Sep 3, 2024

shubham1206agra commented Sep 3, 2024

Julesssss commented Sep 3, 2024

Krishna2323 commented Sep 4, 2024

Julesssss commented Sep 4, 2024

Krishna2323 commented Sep 6, 2024

Krishna2323 commented Sep 9, 2024

Scenario 1 - Location permission is unset (neither denied nor allowed)

Scenario 2 - Location permission is unset (neither denied nor allowed)

Scenario 3 - Location permission is unset (neither denied nor allowed)

Result with current implementation (Changes in this PR)

Julesssss commented Sep 9, 2024 • edited Loading

shubham1206agra commented Sep 9, 2024

Julesssss commented Sep 9, 2024

Julesssss commented Sep 10, 2024

Krishna2323 commented Sep 10, 2024

Krishna2323 commented Sep 11, 2024

Julesssss left a comment

Choose a reason for hiding this comment

Julesssss commented Sep 16, 2024

shubham1206agra Sep 16, 2024

Choose a reason for hiding this comment

Krishna2323 Sep 16, 2024

Choose a reason for hiding this comment

shubham1206agra commented Sep 18, 2024

Krishna2323 commented Sep 18, 2024

shubham1206agra commented Sep 18, 2024

Krishna2323 commented Sep 18, 2024

Julesssss commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

Krishna2323 commented Sep 18, 2024

Krishna2323 commented Sep 19, 2024

Krishna2323 commented Sep 20, 2024

Krishna2323 commented Sep 24, 2024

Krishna2323 commented Oct 1, 2024

shubham1206agra commented Oct 1, 2024

Krishna2323 commented Oct 1, 2024

shubham1206agra commented Oct 3, 2024

Reviewer Checklist

Screenshots/Videos

Krishna2323 commented Aug 29, 2024 •

edited

Loading

Julesssss commented Sep 9, 2024 •

edited

Loading