-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD on #37891] Migrate E/App to use PlatformStackNavigation
#49937
base: main
Are you sure you want to change the base?
[HOLD on #37891] Migrate E/App to use PlatformStackNavigation
#49937
Conversation
…oard handling (appearance from the bottom, blinks on hide gesture)
…reen to be disabled (when settings screen becomes shown again)
Re-assigning to @chiragsalian and @mountiny for review since it looks like they have more context. |
@mountiny or @chiragsalian please from now on create ad-hoc builds from here. I fixed all remaining reported errors yesterday, so we can probably trigger a new build already. |
This comment has been minimized.
This comment has been minimized.
…reen-unmount' into @chrispader/use-platform-stack-navigation-in-app
The ad-hoc iOS build fail is also going to be related to the patch from #49936 |
@mountiny Please run adhoc builds here when you have a moment, i plan to work on testing this fully today |
Running |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
The PR didn't have the changes to the |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
@chrispader Looking great! I think there are two things I have noticed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commenting so this shows on my k2 for easy access
@mountiny @ishpaul777 @chiragsalian
Details
This PR migrates the App to use
PlatformStackNavigation
types and navigator components implemented in #37891HOLD on #37891 to be merged first
Fixed Issues
$ #37891
PROPOSAL: #37891 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop