-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Book travel - Book travel animation becomes blank while RHP is dismissed #50199
Open
layacat
wants to merge
1
commit into
Expensify:main
Choose a base branch
from
layacat:fix-49744
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
suneox
reviewed
Oct 4, 2024
src/components/Lottie/index.tsx
Outdated
@@ -79,19 +79,20 @@ function Lottie({source, webStyle, shouldLoadAfterInteractions, ...props}: Props | |||
return unsubscribeNavigationBlur; | |||
}, [browser, navigationContainerRef, navigator]); | |||
|
|||
// If user is being navigated away, let pause the animation to prevent memory leak. | |||
useEffect(() => { | |||
if (!animationRef || !hasNavigatedAway) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
animationRef
always an object
Suggested change
if (!animationRef || !hasNavigatedAway) { | |
if (!animationRef.current || !hasNavigatedAway) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I fixed it
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-04.at.15.13.22.mp4Android: mWeb ChromeScreen.Recording.2024-10-04.at.15.15.38.mp4iOS: NativeScreen.Recording.2024-10-04.at.14.39.34.mp4iOS: mWeb SafariScreen.Recording.2024-10-04.at.14.44.58.mp4MacOS: Chrome / SafariScreen.Recording.2024-10-04.at.14.33.01.mp4MacOS: DesktopScreen.Recording.2024-10-04.at.14.34.21.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #49744
PROPOSAL: #49744 (comment)
Tests
Offline tests
Same with Tests
QA Steps
Same with Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.native.mov
Android: mWeb Chrome
android.web.mov
iOS: Native
iphone.native.mov
iOS: mWeb Safari
iphone.web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov