Fix single backtick code block is rendered within a triple backtick code block when followed by an emoji #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode block when followed by an emoji
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
melvin-bot
bot
requested review from
carlosmiceli
and removed request for
a team
|
I have read the CLA Document and I hereby sign the CLA |
6 tasks
carlosmiceli
approved these changes
Sep 27, 2024
|
🚀Published to npm in v2.0.94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ Expensify/App#49276
Tests
Updated the unit test to cover an inline code block followed by an emoji within a triple backtick code block.
Update the related regex in the node_modules/expensify-common/dist/ExpensiMark.js and send this in the Expensify composer.
```
`diamond` 💍
```
Verify that the single backtick code block is not rendered within the triple backtick code block.
QA
Same as test above
Tests related to inline code inside code fences.