Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Custom header and footer. Move settings to its own page #17

Merged
merged 8 commits into from
Jan 9, 2025
Merged

feat: Custom header and footer. Move settings to its own page #17

merged 8 commits into from
Jan 9, 2025

Conversation

MatiasArriola
Copy link
Contributor

📌 References

📝 Implementation

  • Header and Footer can be customized in app-config.ts
    • Basic customization options provided only. To be improved later according to requirements.
  • DHIS header is hidden for non-admin users
  • Settings moved from Dialog to a separate page. Also hidden from non-admin users.

🎨 Screenshots

image

@MatiasArriola MatiasArriola requested a review from eperedo January 2, 2025 17:30
eperedo
eperedo requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great just a couple of notes.

src/app-config.ts Outdated Show resolved Hide resolved
src/webapp/hooks/useSettings.ts Outdated Show resolved Hide resolved
@MatiasArriola MatiasArriola requested a review from eperedo January 8, 2025 17:49
eperedo
eperedo requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we're very close. Just some comments about futures and functional programming. Let me know if you have any questions, thanks @MatiasArriola

src/domain/usecases/InitDefaultSettingsUseCase.ts Outdated Show resolved Hide resolved
src/webapp/pages/app/App.tsx Outdated Show resolved Hide resolved
@MatiasArriola
refactor: extract function getSettingsOrInitialize
4d5f71d 
Convert unnecesary flatMap to map
@MatiasArriola
Copy link
Contributor Author

Thanks for your review @eperedo! I've submitted the fixes, let me know if something else comes up.

@MatiasArriola MatiasArriola requested a review from eperedo January 9, 2025 11:57
eperedo
eperedo approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you @MatiasArriola!

@eperedo eperedo merged commit 09fdb42 into feat/ntd-customizations Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eperedo eperedo eperedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatiasArriola @eperedo