Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widp] Implement login with two factor #228

Open
wants to merge 7 commits into
base: develop-widp
Choose a base branch
from

Conversation

xurxodev
Copy link

@xurxodev xurxodev commented Dec 17, 2024

📌 References

⚙️ branches

app:
Origin: feature-widp/implement_two_factor Target: develop-widp
dhis2-android-SDK:
Origin: develop-eyeseetea

🎩 What is the goal?

Implement two factor login

📝 How is it being implemented?

  • handle SDK error when two-factor code is required
  • subscribe to automatic logout and execute it

💥 How can it be tested?

2.41 - user with two-factor code enabled should can to log in
2.41 - user without two-factor code enabled should can to log in
2.40 - user with two-factor code enabled - Not work because new endpoint doesn't exist
2.40 - user without two-factor code enabled should can to log in
2.39 - user with two-factor code enabled - Not work because new endpoint doesn't exist
2.39 - user without two-factor code enabled should can to log in

💾 Requires DB migration?

  • Nope, we can just merge this branch.
  • Yes, but we need to apply it before merging this branch.
  • Yes, it's already applied.

🎨 UI changes?

  • Nope, the UI remains as beautiful as it was before!
  • Yeap, here you have some screenshots-

@xurxodev xurxodev changed the title Feature widp/implement two factor [Widp] Implement two factor Dec 23, 2024
@xurxodev xurxodev changed the title [Widp] Implement two factor [Widp] Implement login with two factor Dec 23, 2024
Base automatically changed from feature-widp/bring_last_changes_3_0_1 to develop-widp January 7, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants